You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openoffice.apache.org by bu...@apache.org on 2015/11/17 03:33:55 UTC

review requested: [Issue 126635] Possible null pointer dereference : [Attachment 85136] patch to main/sw/source/core/doc/poolfmt.cxx

orcmid <or...@apache.org> has asked orcmid <or...@apache.org> for review:
Issue 126635: Possible null pointer dereference
https://bz.apache.org/ooo/show_bug.cgi?id=126635

Attachment 85136: patch to main/sw/source/core/doc/poolfmt.cxx
https://bz.apache.org/ooo/attachment.cgi?id=85136&action=edit



--- Comment #4 from orcmid <or...@apache.org> ---
Created attachment 85136
  --> https://bz.apache.org/ooo/attachment.cgi?id=85136&action=edit
patch to main/sw/source/core/doc/poolfmt.cxx

In the unpatched version, the misplaced check on pColl for NULL caused 
pColl->SetNextTxtFmtColl( ) to never be executed.

In this patch, the final operation is executed when pColl != NULL.

This may cause unexpected behavior if the failure of this operation is
compensated for anywhere else in the code.