You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "AMashenkov (via GitHub)" <gi...@apache.org> on 2025/03/03 15:06:50 UTC
Re: [PR] IGNITE-24564 Add all existing catalog serializers to a single registry [ignite-3]
AMashenkov commented on code in PR #5293:
URL: https://github.com/apache/ignite-3/pull/5293#discussion_r1977679483
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -461,12 +461,16 @@ public List<SystemView<?>> systemViews() {
class OnUpdateHandlerImpl implements OnUpdateHandler {
@Override
- public CompletableFuture<Void> handle(UpdateLogEvent event, HybridTimestamp metaStorageUpdateTimestamp, long causalityToken) {
+ public CompletableFuture<Void> handle(MarshallableEntry event, HybridTimestamp metaStorageUpdateTimestamp, long causalityToken) {
Review Comment:
Previous signature was better. The method doesn't accepts arbitrary MarshallableEntry, but only top-level entries: Snapshot and VersionedUpdate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org