You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by atrbgithub <gi...@git.apache.org> on 2015/11/05 13:05:21 UTC
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
GitHub user atrbgithub opened a pull request:
https://github.com/apache/cloudstack/pull/1037
Fix for CLOUDSTACK-8937 - XenServer migrations with storage failing i…
…n clustered management server environment
This pull request relates to the following Jira bug report:
https://issues.apache.org/jira/browse/CLOUDSTACK-8937
A previous fix was proposed for the 4.5 branch here: https://github.com/apache/cloudstack/pull/925
This was tested within a working environment and everything appeared to work fine.
@remibergsma Unfortunately I have not been able to test this within a running environment. Everything appears to compile ok and tests pass. I believe you are much further along in the Cloudstack automated testing arena, so I'm not sure if this is something you would be able to test at some point in the future?
If not I will be able to test it when my current workload permits and report back here with my findings.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/autotraderuk/cloudstack 4.6-CS-8937
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1037
----
commit 1e505e08883f4735c70e9d0de03d24efe990ed2a
Author: atrbgithub <at...@gmail.com>
Date: 2015-11-05T11:53:55Z
Fix for CLOUDSTACK-8937 - XenServer migrations with storage failing in clustered management server environment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1037#issuecomment-162824106
Ping @bhaisaab @atrbgithub
If I get some details on how to test - steps - I can give it a try.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1037#issuecomment-162995054
Hi @atrbgithub
Yes, the info clarifies feel things, but unfortunately I'm also busy and do not have time to write a test to cover it. I also have some refactoring/development to do and cannot be 100% allocated to write tests to run against other PRs.
Since you mentioned in your comment that ```Everything appears to compile ok and tests pass``` I thought you were talking about existing integration tests.
Unfortunately, unless someone tests this PR with the setup provided by @atrbgithub, I will have to hold a :-1: against it.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1037: Fix for CLOUDSTACK-8937 - XenServer migrations with ...
Posted by atrbgithub <gi...@git.apache.org>.
Github user atrbgithub commented on the issue:
https://github.com/apache/cloudstack/pull/1037
I believe this can be closed now. https://github.com/apache/cloudstack/pull/1336 and https://github.com/apache/cloudstack/pull/1596 address this problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1037#issuecomment-216195896
@atrbgithub please rebase against latest master and push -f, update on status of your PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1037#issuecomment-158875003
LGTM, anyone tested this yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by atrbgithub <gi...@git.apache.org>.
Github user atrbgithub commented on the pull request:
https://github.com/apache/cloudstack/pull/1037#issuecomment-162829832
Hi @wilderrodrigues
To test this you would need to have 2 or more cloudstack management servers operating in a cluster with Xen hosts. Before applying this fix, when you try to live migrate vm's between hosts (root disks on local storage or primary storage), occasionally this will fail. It is random depending on which management servers are allocated the job.
After applying the change in the pull request, migrations should no longer fail.
Hope that is ok.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---