You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2018/11/09 17:57:53 UTC

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior 

Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11917


Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................

IMPALA-5031: signed overflow is undefined behavior

This patch fixes a signed overflow in the backend test
DecimalTest.Overflow. The interesting part of the backtrace is:

runtime/decimal-value.inline.h:254:17: runtime error: signed integer
         overflow: 0x4b3b4ca85a86c47a098a223fffffffff +
         0x4b3b4ca85a86c47a098a223fffffffff cannot be represented in
         type '__int128'
    #0 detail::AddLarge(__int128, int, __int128, int, int, bool,
         bool*) runtime/decimal-value.inline.h:254:17
    #1 DecimalValue<__int128> DecimalValue<__int128>::Add<__int128>(
         int, DecimalValue<__int128> const&, int, int, int, bool,
         bool*) const runtime/decimal-value.inline.h:371:14
    #2 DecimalTest_Overflow_Test::TestBody()
         runtime/decimal-test.cc:540:9

Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
---
M be/src/runtime/decimal-value.inline.h
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/11917/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11917 )

Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3471/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Nov 2018 16:06:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11917 )

Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3471/


-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Nov 2018 20:26:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11917 )

Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Nov 2018 06:50:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11917 )

Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................

IMPALA-5031: signed overflow is undefined behavior

This patch fixes a signed overflow in the backend test
DecimalTest.Overflow. The interesting part of the backtrace is:

runtime/decimal-value.inline.h:254:17: runtime error: signed integer
         overflow: 0x4b3b4ca85a86c47a098a223fffffffff +
         0x4b3b4ca85a86c47a098a223fffffffff cannot be represented in
         type '__int128'
    #0 detail::AddLarge(__int128, int, __int128, int, int, bool,
         bool*) runtime/decimal-value.inline.h:254:17
    #1 DecimalValue<__int128> DecimalValue<__int128>::Add<__int128>(
         int, DecimalValue<__int128> const&, int, int, int, bool,
         bool*) const runtime/decimal-value.inline.h:371:14
    #2 DecimalTest_Overflow_Test::TestBody()
         runtime/decimal-test.cc:540:9

Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Reviewed-on: http://gerrit.cloudera.org:8080/11917
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/decimal-value.inline.h
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jim Apple: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11917 )

Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................


Patch Set 2:

Failure looks flaky to me; rerunning


-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Nov 2018 02:39:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11917 )

Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1345/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Nov 2018 18:38:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11917 )

Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3472/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Nov 2018 02:39:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11917 )

Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................


Patch Set 2: Code-Review+2

carry Tim's


-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Nov 2018 16:05:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11917 )

Change subject: IMPALA-5031: signed overflow is undefined behavior
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I146bcf35d34cc0e14be0633427d3e4bd0e5a261e
Gerrit-Change-Number: 11917
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 01:09:46 +0000
Gerrit-HasComments: No