You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/09/13 22:08:29 UTC

[GitHub] [spark] amaliujia commented on a diff in pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api

amaliujia commented on code in PR #42092:
URL: https://github.com/apache/spark/pull/42092#discussion_r1325124633


##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
     ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
     ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
 
+    // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+    ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),

Review Comment:
   @LuciferYang 
   
   The intention here is to exclude these from spark 3.4 Mima check and I expected once we release Spark 3.5, these will be deleted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org