You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2025/03/31 16:01:06 UTC
[PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
assignUser opened a new pull request, #45981:
URL: https://github.com/apache/arrow/pull/45981
### Rationale for this change
CMake 4.0 removed 3.5 as a viable minimum version.
### What changes are included in this PR?
Bump bundled snappy.
### Are these changes tested?
CI
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2769273590
@github-actions crossbow submit -g cpp r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2766689962
@github crossbow submit test-conda-python-emscripten r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #45981:
URL: https://github.com/apache/arrow/pull/45981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2769272431
@github-actions crossbow submit test-conda-python-emscripten
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2768594267
Revision: 61d9a6d86cceb54be7ad4e22a7a330a87cb864b1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-43a7b8e298](https://github.com/ursacomputing/crossbow/branches/all?query=actions-43a7b8e298)
|Task|Status|
|----|------|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14190939081/job/39755256634)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2766721988
Revision: 61d9a6d86cceb54be7ad4e22a7a330a87cb864b1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4f13d7efec](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4f13d7efec)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14176185102/job/39711547418)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14176184903/job/39711546456)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2768691481
I am just confused on why the job uses CMake 4.0 on CI but I have to force installation of CMake 4.0 locally even when forcing rebuilding local images, etcetera.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2769257864
Can you rebase this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2769281159
Revision: 77ec39fa036241ea900958ed225e201d357831d8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3d90fd57f2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3d90fd57f2)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/14196241711/job/39771925312)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242164/job/39771927112)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/14196241600/job/39771925428)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242590/job/39771929914)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242129/job/39771927051)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242893/job/39771930640)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242374/job/39771928834)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242474/job/39771929284)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242313/job/39771928476)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242177/job/39771927764)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14196241868/job/39771926142)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242512/job/39771929508)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242641/job/39771929988)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196241747/job/39771925879)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242204/job/39771927753)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242967/job/39771930650)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242455/job/39771928898)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242132/job/39771927117)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242322/job/39771928396)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242255/job/39771928044)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14196241592/job/39771925351)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242661/job/39771930081)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242412/job/39771928730)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14196242588/job/39771929719)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2772186548
@github-actions crossbow submit test-ubuntu-22.04-cpp-emscripten
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2768588468
@github-actions crossbow submit test-conda-python-emscripten
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45981:
URL: https://github.com/apache/arrow/pull/45981#discussion_r2024257546
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -958,6 +958,9 @@ set(EP_COMMON_CMAKE_ARGS
-DCMAKE_INSTALL_LIBDIR=lib
-DCMAKE_OSX_SYSROOT=${CMAKE_OSX_SYSROOT}
-DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE}
+ # We set CMAKE_POLICY_VERSION_MINIMUM temporarily due to failures with CMake 4
+ # We should remove it once we have updated the dependencies:
+ # https://github.com/apache/arrow/issues/45985
-DCMAKE_POLICY_VERSION_MINIMUM=3.5)
Review Comment:
Can we disable this in `build_snappy`?
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index f4de617ced..21676ea5f1 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1387,6 +1387,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
+ # We can remove this once we remove -DCMAKE_POLICY_VERSION_MINIMUM=3.5
+ # from EP_COMMON_CMAKE_ARGS.
+ list(REMOVE_ITEM SNAPPY_CMAKE_ARGS -DCMAKE_POLICY_VERSION_MINIMUM=3.5)
# Snappy unconditionally enables -Werror when building with clang this can lead
# to build failures by way of new compiler warnings. This adds a flag to disable
# -Werror to the very end of the invocation to override the snappy internal setting.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2773715201
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 686971e1b573f22a82f78bfa6feb271d4ffc3d4e.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/39876485636) has more details. It also includes information about 30 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45980: [C++] Bump Bundled Snappy version to 1.2.2 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45981:
URL: https://github.com/apache/arrow/pull/45981#issuecomment-2772191483
Revision: 7652f190642e1256b3efe00afd08af8abbee9017
Submitted crossbow builds: [ursacomputing/crossbow @ actions-736994d413](https://github.com/ursacomputing/crossbow/branches/all?query=actions-736994d413)
|Task|Status|
|----|------|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14217874145/job/39838632802)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org