You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Pascal Schumacher <pa...@gmx.net> on 2020/02/02 16:29:14 UTC
camel-spring-boot: Disable JMX by default?
Hi,
Spring Boot 2.2 disables JMX by default (see:
https://github.com/spring-projects/spring-boot/issues/16090).
Should we follow suit and change the default of spring-boot?
What do you think?
-Pascal
Re: camel-spring-boot: Disable JMX by default?
Posted by Pascal Schumacher <pa...@gmx.net>.
If removing the dependency is enough to disable it I think we should
just remove the dependency.
I created https://issues.apache.org/jira/browse/CAMEL-14481
Thanks,
Pascal
Am 03.02.2020 um 10:11 schrieb Claus Ibsen:
> Hi
>
> Ah okay, yeah we should likely remove camel-management as a dependency
> for camel-spring-boot, then JMX is disabled out of the box.
> And maybe even also set the configuration option to false. But then to
> enable it you need both to add the JAR and set the option to true
>
> Can you create a JIRA.
>
> On Sun, Feb 2, 2020 at 11:39 PM Pascal Schumacher
> <pa...@gmx.net> wrote:
>> Am 02.02.2020 um 18:29 schrieb Claus Ibsen:
>>> Hi
>>>
>>> This is only Spring Boot JMX, and spring boot may not have so much
>>> data in JMX that anybody are using it.
>> Yes, Spring Boot does not offer as much JMX data as Camel. On the flip
>> side Camel JMX needs more memory (as far as I remember, haven't checked
>> recently).
>>
>> Other than Spring JMX (and JMX for Spring Components like Spring Batch
>> and Spring Integration) Spring Boot 2.2 also disabled Tomcat JMX by
>> default (see: https://github.com/spring-projects/spring-boot/issues/16498).
>>
>>> But I see the point, but what Camel does in 3.x is to make JMX
>>> optional if you have camel-management on the classpath or not.
>>> And of course allows to configure this as well with those options.
>>>
>>> Can you check the 3.0 spring boot example and see if camel-management
>>> gets added out of the box or not?
>>> We may have added it specially for camel-spring-boot to make it JMX
>>> out of the box.
>> Yes, camel-spring-boot has a compile camel-management dependency, so it
>> is added out of the box.
>>
>> -Pascal
>>
>
Re: camel-spring-boot: Disable JMX by default?
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
Ah okay, yeah we should likely remove camel-management as a dependency
for camel-spring-boot, then JMX is disabled out of the box.
And maybe even also set the configuration option to false. But then to
enable it you need both to add the JAR and set the option to true
Can you create a JIRA.
On Sun, Feb 2, 2020 at 11:39 PM Pascal Schumacher
<pa...@gmx.net> wrote:
>
> Am 02.02.2020 um 18:29 schrieb Claus Ibsen:
> > Hi
> >
> > This is only Spring Boot JMX, and spring boot may not have so much
> > data in JMX that anybody are using it.
>
> Yes, Spring Boot does not offer as much JMX data as Camel. On the flip
> side Camel JMX needs more memory (as far as I remember, haven't checked
> recently).
>
> Other than Spring JMX (and JMX for Spring Components like Spring Batch
> and Spring Integration) Spring Boot 2.2 also disabled Tomcat JMX by
> default (see: https://github.com/spring-projects/spring-boot/issues/16498).
>
> > But I see the point, but what Camel does in 3.x is to make JMX
> > optional if you have camel-management on the classpath or not.
> > And of course allows to configure this as well with those options.
> >
> > Can you check the 3.0 spring boot example and see if camel-management
> > gets added out of the box or not?
> > We may have added it specially for camel-spring-boot to make it JMX
> > out of the box.
>
> Yes, camel-spring-boot has a compile camel-management dependency, so it
> is added out of the box.
>
> -Pascal
>
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: camel-spring-boot: Disable JMX by default?
Posted by Pascal Schumacher <pa...@gmx.net>.
Am 02.02.2020 um 18:29 schrieb Claus Ibsen:
> Hi
>
> This is only Spring Boot JMX, and spring boot may not have so much
> data in JMX that anybody are using it.
Yes, Spring Boot does not offer as much JMX data as Camel. On the flip
side Camel JMX needs more memory (as far as I remember, haven't checked
recently).
Other than Spring JMX (and JMX for Spring Components like Spring Batch
and Spring Integration) Spring Boot 2.2 also disabled Tomcat JMX by
default (see: https://github.com/spring-projects/spring-boot/issues/16498).
> But I see the point, but what Camel does in 3.x is to make JMX
> optional if you have camel-management on the classpath or not.
> And of course allows to configure this as well with those options.
>
> Can you check the 3.0 spring boot example and see if camel-management
> gets added out of the box or not?
> We may have added it specially for camel-spring-boot to make it JMX
> out of the box.
Yes, camel-spring-boot has a compile camel-management dependency, so it
is added out of the box.
-Pascal
Re: camel-spring-boot: Disable JMX by default?
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
This is only Spring Boot JMX, and spring boot may not have so much
data in JMX that anybody are using it.
But I see the point, but what Camel does in 3.x is to make JMX
optional if you have camel-management on the classpath or not.
And of course allows to configure this as well with those options.
Can you check the 3.0 spring boot example and see if camel-management
gets added out of the box or not?
We may have added it specially for camel-spring-boot to make it JMX
out of the box.
On Sun, Feb 2, 2020 at 5:29 PM Pascal Schumacher
<pa...@gmx.net> wrote:
>
> Hi,
>
> Spring Boot 2.2 disables JMX by default (see:
> https://github.com/spring-projects/spring-boot/issues/16090).
>
> Should we follow suit and change the default of spring-boot?
>
> What do you think?
>
> -Pascal
>
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2