[GitHub] [incubator-pinot] kishoreg commented on pull request #6375: make MAX_NUM_THREADS_PER_QUERY configurable for pinto server

[GitBox <gi...@apache.org>]

kishoreg commented on pull request #6375:
URL: https://github.com/apache/incubator-pinot/pull/6375#issuecomment-749366869


   > > Why are we using the JVM system property based mechanism to set this as opposed to using pinot.server.* configurations which is how we set the server instance config?
   > > Also I feel as opposed to making this as a server/instance level config, we should allow this as a table level config or at least both. Will be useful for multi-tenancy and later on implementing query or table level priority. There is a queryConfig field in table config which is used to pass down the table level query timeout information. I think we can enhance QueryConfig to pass down this information as well.
   > 
   > +1 to not using jvm property, and use what pinot does with other config items.
   > 
   > Number of threads to use does seem to be a per-system property, though. Even in a multi-tenant system, the table configs will have to carry a weighted value for num threads, which will get hard to provision across tables. I think having this as a per-host config is better.
   
   why per host? it's better to control this per table right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org