[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #558: [Followup #249] Cleanup code and unify interfaces

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on code in PR #558:
URL: https://github.com/apache/incubator-uniffle/pull/558#discussion_r1099578320


##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -361,8 +362,9 @@ private void addPendingEventsInternal(PendingShuffleFlushEvent event) {
     }
   }
 
-  public void removeResourcesOfShuffleId(String appId, int shuffleId) {
-    Optional.ofNullable(committedBlockIds.get(appId)).ifPresent(x -> x.remove(shuffleId));
+  public void removeResourcesOfShuffleId(String appId, Collection<Integer> shuffleIds) {

Review Comment:
   > IMO, this should be called `removeResourceOfShuffleIds`?
   
   This is aligned with `removeBufferByShuffleId`.
   
   > And another singular method `removeResourceOfShuffleId` should be added?
   
   There is no usage elsewhere now. We can add it when needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org