You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "asl3 (via GitHub)" <gi...@apache.org> on 2023/07/28 21:09:46 UTC

[GitHub] [spark] asl3 commented on a diff in pull request #42023: [SPARK-44446][PYTHON] Add checks for expected list type special cases

asl3 commented on code in PR #42023:
URL: https://github.com/apache/spark/pull/42023#discussion_r1278085441


##########
python/pyspark/sql/tests/test_utils.py:
##########
@@ -1119,6 +1119,30 @@ def test_empty_no_column(self):
         assertDataFrameEqual(df1, df2, checkRowOrder=False)
         assertDataFrameEqual(df1, df2, checkRowOrder=True)
 
+    def test_empty_expected_list(self):
+        df1 = self.spark.range(0, 10).drop("id")
+
+        df2 = []

Review Comment:
   thanks, fixing in [#42196](https://github.com/apache/spark/pull/42196)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org