You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/17 11:57:52 UTC
[GitHub] [arrow] kszucs opened a new pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
kszucs opened a new pull request #10342:
URL: https://github.com/apache/arrow/pull/10342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842265442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842326554
@github-actions crossbow submit python-sdist
This should test the produced source tarball in a git-less environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842266456
@github-actions crossbow submit python-sdist wheel-*
Still need to verify this locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10342:
URL: https://github.com/apache/arrow/pull/10342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842266456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842307624
I'm updating the sdist build to check the tarball without git installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842517925
The produced artifacts are here https://github.com/ursacomputing/crossbow/releases/tag/actions-415-github-java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#discussion_r633744314
##########
File path: ci/scripts/python_sdist_test.sh
##########
@@ -42,10 +42,16 @@ export PYARROW_WITH_DATASET=${ARROW_DATASET:-OFF}
# unset ARROW_HOME
# apt purge -y pkg-config
+# ARROW-12619
+if command -v git &> /dev/null; then
+ echo "Git exists, remove it from PATH before executing this script."
+ exit 1
+fi
+
if [ -n "${PYARROW_VERSION:-}" ]; then
sdist="${arrow_dir}/python/dist/pyarrow-${PYARROW_VERSION}.tar.gz"
else
- sdist=$(ls "${arrow_dir}/python/dist/pyarrow-*.tar.gz" | sort -r | head -n1)
+ sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
Review comment:
very minor nit: you could keep the quoting around just `${arrow_dir}`
##########
File path: ci/scripts/python_sdist_test.sh
##########
@@ -42,10 +42,16 @@ export PYARROW_WITH_DATASET=${ARROW_DATASET:-OFF}
# unset ARROW_HOME
# apt purge -y pkg-config
+# ARROW-12619
+if command -v git &> /dev/null; then
+ echo "Git exists, remove it from PATH before executing this script."
+ exit 1
+fi
+
if [ -n "${PYARROW_VERSION:-}" ]; then
sdist="${arrow_dir}/python/dist/pyarrow-${PYARROW_VERSION}.tar.gz"
else
- sdist=$(ls "${arrow_dir}/python/dist/pyarrow-*.tar.gz" | sort -r | head -n1)
+ sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
Review comment:
That is expected, but `ls "${arrow_dir}"/python/dist/pyarrow-*.tar.gz` doesn't work? e.g.
```
$ export arrow_dir=/tmp/foo
$ touch /tmp/foo/pyarrow-5.0.0.tar.gz
$ ls "${arrow_dir}"/pyarrow-*.tar.gz
/tmp/foo/pyarrow-5.0.0.tar.gz
```
but either way this is a very minor nit, just if you wanted to be extra-defensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs removed a comment on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
kszucs removed a comment on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842517925
The produced artifacts are here https://github.com/ursacomputing/crossbow/releases/tag/actions-415-github-java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs removed a comment on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
kszucs removed a comment on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842517925
The produced artifacts are here https://github.com/ursacomputing/crossbow/releases/tag/actions-415-github-java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842265442
https://issues.apache.org/jira/browse/ARROW-12619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842267063
Revision: 49641009eca010447e733678018415376081973a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-414](https://github.com/ursacomputing/crossbow/branches/all?query=actions-414)
|Task|Status|
|----|------|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-python-sdist)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-osx-high-sierra-cp36|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-osx-high-sierra-cp36)|
|wheel-osx-high-sierra-cp37|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-osx-high-sierra-cp37)|
|wheel-osx-high-sierra-cp38|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-osx-high-sierra-cp38)|
|wheel-osx-high-sierra-cp39|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-osx-high-sierra-cp39)|
|wheel-osx-mavericks-cp36|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-osx-mavericks-cp36)|
|wheel-osx-mavericks-cp37|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-osx-mavericks-cp37)|
|wheel-osx-mavericks-cp38|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-osx-mavericks-cp38)|
|wheel-osx-mavericks-cp39|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-osx-mavericks-cp39)|
|wheel-windows-cp36|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-windows-cp36)|
|wheel-windows-cp37|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-windows-cp37)|
|wheel-windows-cp38|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-windows-cp38)|
|wheel-windows-cp39|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-414-github-wheel-windows-cp39)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#issuecomment-842331455
Revision: c423b9620f5b8dd33c9a1f2dc9fa527d42d34587
Submitted crossbow builds: [ursacomputing/crossbow @ actions-416](https://github.com/ursacomputing/crossbow/branches/all?query=actions-416)
|Task|Status|
|----|------|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-416-github-python-sdist)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10342: ARROW-12619: [Python] pyarrow sdist should not require git
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10342:
URL: https://github.com/apache/arrow/pull/10342#discussion_r633746897
##########
File path: ci/scripts/python_sdist_test.sh
##########
@@ -42,10 +42,16 @@ export PYARROW_WITH_DATASET=${ARROW_DATASET:-OFF}
# unset ARROW_HOME
# apt purge -y pkg-config
+# ARROW-12619
+if command -v git &> /dev/null; then
+ echo "Git exists, remove it from PATH before executing this script."
+ exit 1
+fi
+
if [ -n "${PYARROW_VERSION:-}" ]; then
sdist="${arrow_dir}/python/dist/pyarrow-${PYARROW_VERSION}.tar.gz"
else
- sdist=$(ls "${arrow_dir}/python/dist/pyarrow-*.tar.gz" | sort -r | head -n1)
+ sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
Review comment:
Interestingly it didn't pick up the tarball with the quotes, which I wouldn't have expected either.
##########
File path: ci/scripts/python_sdist_test.sh
##########
@@ -42,10 +42,16 @@ export PYARROW_WITH_DATASET=${ARROW_DATASET:-OFF}
# unset ARROW_HOME
# apt purge -y pkg-config
+# ARROW-12619
+if command -v git &> /dev/null; then
+ echo "Git exists, remove it from PATH before executing this script."
+ exit 1
+fi
+
if [ -n "${PYARROW_VERSION:-}" ]; then
sdist="${arrow_dir}/python/dist/pyarrow-${PYARROW_VERSION}.tar.gz"
else
- sdist=$(ls "${arrow_dir}/python/dist/pyarrow-*.tar.gz" | sort -r | head -n1)
+ sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
Review comment:
```console
Creating arrow_ubuntu-python-sdist-test_run ... done
root@202aa2bdd8d0:/# ls "/arrow/python/dist/pyarrow-*.tar.gz"
ls: cannot access '/arrow/python/dist/pyarrow-*.tar.gz': No such file or directory
root@202aa2bdd8d0:/# ls /arrow/python/dist/pyarrow-*.tar.gz
/arrow/python/dist/pyarrow-5.0.0.dev866+g49641009e.d20210517.tar.gz
root@202aa2bdd8d0:/#
```
##########
File path: ci/scripts/python_sdist_test.sh
##########
@@ -42,10 +42,16 @@ export PYARROW_WITH_DATASET=${ARROW_DATASET:-OFF}
# unset ARROW_HOME
# apt purge -y pkg-config
+# ARROW-12619
+if command -v git &> /dev/null; then
+ echo "Git exists, remove it from PATH before executing this script."
+ exit 1
+fi
+
if [ -n "${PYARROW_VERSION:-}" ]; then
sdist="${arrow_dir}/python/dist/pyarrow-${PYARROW_VERSION}.tar.gz"
else
- sdist=$(ls "${arrow_dir}/python/dist/pyarrow-*.tar.gz" | sort -r | head -n1)
+ sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
Review comment:
`$arrow_dir` is going to be `/arrow` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org