[GitHub] [incubator-kyuubi] jiaoqingbo commented on a diff in pull request #2286: [KYUUBI #2281] The RenewDelegationToken method of TFrontendService should return SUCCESS_STATUS by default

[GitBox <gi...@apache.org>]

jiaoqingbo commented on code in PR #2286:
URL: https://github.com/apache/incubator-kyuubi/pull/2286#discussion_r847871849


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -498,30 +498,29 @@ abstract class TFrontendService(name: String)
     resp
   }
 
-  private def notSupportTokenErrorStatus = {
-    val errorStatus = new TStatus(TStatusCode.ERROR_STATUS)
-    errorStatus.setErrorMessage("Delegation token is not supported")
-    errorStatus
+  private def supportTokenStatus = {
+    val successStatus = new TStatus(TStatusCode.SUCCESS_STATUS)
+    successStatus
   }
 
   override def GetDelegationToken(req: TGetDelegationTokenReq): TGetDelegationTokenResp = {
     debug(req.toString)
     val resp = new TGetDelegationTokenResp()
-    resp.setStatus(notSupportTokenErrorStatus)
+    resp.setStatus(supportTokenStatus)
     resp
   }
 
   override def CancelDelegationToken(req: TCancelDelegationTokenReq): TCancelDelegationTokenResp = {
     debug(req.toString)
     val resp = new TCancelDelegationTokenResp
-    resp.setStatus(notSupportTokenErrorStatus)
+    resp.setStatus(supportTokenStatus)
     resp
   }
 
   override def RenewDelegationToken(req: TRenewDelegationTokenReq): TRenewDelegationTokenResp = {
     debug(req.toString)
     val resp = new TRenewDelegationTokenResp
-    resp.setStatus(notSupportTokenErrorStatus)
+    resp.setStatus(supportTokenStatus)

Review Comment:
   I will change it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org