[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #847: [#845] feat(storage): Introduce available space based storage choosing policy

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #847:
URL: https://github.com/apache/incubator-uniffle/pull/847#discussion_r1186984368


##########
docs/server_guide.md:
##########
@@ -91,6 +91,7 @@ This document will introduce how to deploy Uniffle shuffle servers.
 | rss.server.max.concurrency.of.single.partition.writer | 1       | The max concurrency of single partition writer, the data partition file number is equal to this value. Default value is 1. This config could improve the writing speed, especially for huge partition.                                                                                                                                                                                   |
 | rss.metrics.reporter.class                            | -       | The class of metrics reporter.                                                                                                                                                                                                                                                                                                                                                           |
 |rss.server.multistorage.manager.selector.class         | org.apache.uniffle.server.storage.multi.DefaultStorageManagerSelector | The manager selector strategy for `MEMORY_LOCALFILE_HDFS`. Default value is `DefaultStorageManagerSelector`, and another `HugePartitionSensitiveStorageManagerSelector` will flush only huge partition's data to cold storage.                                                                                             |
+|rss.server.localstorage.storage.choosing.policy.class|org.apache.uniffle.server.storage.local.HashStorageChoosingPolicy|For localstorage, the storage choosing policy is for per-partition. Default value is the hash-based disk selector.|

Review Comment:
   these two configurations seems related. Do you think it's possible to merge these configurations in next release, so users don't have to be confused by too many configurations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org