You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/22 06:28:32 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #5136: apiserver : Ensure required parameters are not empty
davidjumani opened a new pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136
### Description
Addon to https://github.com/apache/cloudstack/pull/5135
Ensures that any required parameter is not empty / null
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865861808
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#discussion_r657610556
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java
##########
@@ -94,7 +94,6 @@
@Parameter(name = ApiConstants.SUPPORTED_SERVICES,
type = CommandType.LIST,
- required = true,
Review comment:
Aha, looks like a legacy restriction that no longer is necessary.
@davidjumani thanks for the clarification :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871922999
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-867310125
@blueorangutan test centos7 vmware-65u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871985940
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865883699
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865651724
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871369708
@davidjumani I understand that optional parameters passed in the API are ignored, but these are still not null. In any case, the parameter value returned based on not null check, there can be issue (for example, not null Boolean params can be interpreted as true/false (whatever default value for Boolean in java), and the default parameter value is the opposite).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-872469513
<b>Trillian test result (tid-1184)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39907 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5136-t1184-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 84.75 | test_kubernetes_clusters.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.13 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-866513651
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865651724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865650926
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#discussion_r657607350
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java
##########
@@ -94,7 +94,6 @@
@Parameter(name = ApiConstants.SUPPORTED_SERVICES,
type = CommandType.LIST,
- required = true,
Review comment:
For L2 network offerings, there are cases when there are no services, and an empty list is sent, so marking it as not required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871919965
> @sureshanaparti There are no changes to optional parameters, only parameters with required=true will now have to not be empty
As the required parameters are validated here, before validating them through the _validations_ annotation, this annotation `validations = {ApiArgValidator.NotNullOrEmpty}` is no longer valid for required parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-866522305
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-866522610
@davidjumani a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871922628
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871943367
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871910957
@sureshanaparti There are no changes to optional parameters, only parameters with required=true will now have to not be empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-866509908
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-866513745
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#discussion_r660354481
##########
File path: server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
##########
@@ -159,6 +159,9 @@ public void processParameters(final BaseCmd cmd, final Map params) {
}
continue;
}
+ if (parameterAnnotation.required()){
+ validateNonEmptyString(paramObj, parameterAnnotation.name());
Review comment:
LGTM - my only worry is if it causes a regression as it create a new behaviour (nit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865650926
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865882984
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865691476
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871369708
@davidjumani I understand that optional parameters passed in the API are ignored, but these are still not null. In any case, the parameter value return based on not null check, there can be issue (for example, not null Boolean params can be interpreted as true/false (whatever default value for Boolean in java), and the default parameter value is the opposite).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-867310265
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-866510052
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-866351585
<b>Trillian test result (tid-1039)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36304 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5136-t1039-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_direct_download.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_persistent_network.py
Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 82 look OK, 6 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestL2Networks>:setup | `Error` | 175.74 | test_network.py
ContextSuite context=TestDirectDownloadTemplates>:setup | `Error` | 0.00 | test_direct_download.py
ContextSuite context=TestL2PersistentNetworks>:setup | `Error` | 0.00 | test_persistent_network.py
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
ContextSuite context=TestUnmanageVM>:setup | `Error` | 202.06 | test_vm_life_cycle.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.12 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.15 | test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:setup | `Error` | 0.22 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871369708
@davidjumani I understand that optional parameters passed in the API are ignored, but these are still not null. In any case, the parameter value returned based on not null check, there can be issue (for example, not null Boolean params can be interpreted as true/false - whatever default value for Boolean in java, and the default parameter value is the opposite).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871143880
rekicked the final failing travis job (5) but i think we can merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#discussion_r657604209
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java
##########
@@ -94,7 +94,6 @@
@Parameter(name = ApiConstants.SUPPORTED_SERVICES,
type = CommandType.LIST,
- required = true,
Review comment:
Is there any update on the API command [createNetworkOffering](https://cloudstack.apache.org/api/apidocs-4.15/apis/createNetworkOffering.html) that I am not aware of?
As far as I know, `supportedservices` is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-866984189
<b>Trillian test result (tid-1044)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37848 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5136-t1044-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865825449
<b>Trillian Build Failed (tid-1037)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865879269
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-866521972
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871985633
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865861155
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871943697
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#discussion_r660354481
##########
File path: server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
##########
@@ -159,6 +159,9 @@ public void processParameters(final BaseCmd cmd, final Map params) {
}
continue;
}
+ if (parameterAnnotation.required()){
+ validateNonEmptyString(paramObj, parameterAnnotation.name());
Review comment:
LGTM - my only worry is if it causes a regression as it create a new behaviour (nit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-869064431
<b>Trillian test result (tid-1115)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36752 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5136-t1115-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
runTest | `Error` | 0.00 | test_nic.py
test_01_migrate_VM_and_root_volume | `Error` | 113.55 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 102.44 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-867022897
<b>Trillian test result (tid-1045)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41453 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5136-t1045-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 532.32 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-871968824
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865673336
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865705222
<b>Trillian Build Failed (tid-1036)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org