You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/01/12 09:43:41 UTC

[GitHub] kramasamy commented on a change in pull request #3154: Fix docker build artifacts script to have the correct version string

kramasamy commented on a change in pull request #3154: Fix docker build artifacts script to have the correct version string
URL: https://github.com/apache/incubator-heron/pull/3154#discussion_r247308087
 
 

 ##########
 File path: docker/scripts/compile-docker.sh
 ##########
 @@ -51,7 +51,7 @@ echo "Running build in container"
 docker run \
     --rm \
     -e TARGET_PLATFORM=$TARGET_PLATFORM \
-    -e SCRATCH_DIR="/scratch" \
+    -e SCRATCH_DIR="/$HERON_VERSION" \
 
 Review comment:
   This is not the right fix. SCRATCH_DIR is used to create directory

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services