You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wusamzong (via GitHub)" <gi...@apache.org> on 2023/02/01 09:43:55 UTC
[GitHub] [yunikorn-core] wusamzong opened a new pull request, #499: [YUNIKORN-1551] remove unused parameter from ClusterContext.addNode()
wusamzong opened a new pull request, #499:
URL: https://github.com/apache/yunikorn-core/pull/499
### What is this PR for?
I remove the unused parameter called node Count.
Where the function is used is also modified.
### What type of PR is it?
* [x] - Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN1551/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #499: [YUNIKORN-1551] remove unused parameter from ClusterContext.addNode()
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #499: [YUNIKORN-1551] remove unused parameter from ClusterContext.addNode()
URL: https://github.com/apache/yunikorn-core/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #499: [YUNIKORN-1551] remove unused parameter from ClusterContext.addNode()
Posted by codecov.
codecov[bot] commented on PR #499:
URL: https://github.com/apache/yunikorn-core/pull/499#issuecomment-1411759405
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/499?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#499](https://codecov.io/gh/apache/yunikorn-core/pull/499?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (250d7e5) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/bd6bf01e2e48e77ae2e90bd812a1ef1bee1409ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd6bf01) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #499 +/- ##
=======================================
Coverage 73.43% 73.43%
=======================================
Files 69 69
Lines 10458 10458
=======================================
Hits 7680 7680
Misses 2531 2531
Partials 247 247
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/yunikorn-core/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `30.32% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org