[jira] [Commented] (TS-849) proxy.config.http.slow.log.threshold is unable to set from traffic_line -s

["Zhao Yongming (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080799#comment-13080799 ] 

Zhao Yongming commented on TS-849:
----------------------------------

it turns out to be that we incorrectly handle RecCheckT = RECC_INT and checking regex pattern is set to "^[0-
9]+$". all RECC_INT checking is band to recordRangeCheck(), while it does not handle plain regex pattern.

there is some others need to change:
{code}
  {RECT_CONFIG, "proxy.config.http.server_max_connections", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_INT, "^[0-9]+$", RECA_NULL}
  ,
  {RECT_CONFIG, "proxy.config.http.origin_max_connections", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_INT, "^[0-9]+$", RECA_NULL}
  ,
  {RECT_CONFIG, "proxy.config.http.origin_min_keep_alive_connections", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_INT, "^[0-9]+$", RECA_NULL}
  {RECT_CONFIG, "proxy.config.http.slow.log.threshold", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_INT, "^[0-9]+$", RECA_NULL}
  {RECT_CONFIG, "proxy.config.net.defer_accept", RECD_INT,
#ifdef TCP_DEFER_ACCEPT
   "45",
#else
   "1",
#endif
   RECU_DYNAMIC, RR_NULL, RECC_INT, "^[0-9]+$", RECA_NULL}
{code}

> proxy.config.http.slow.log.threshold is unable to set from traffic_line -s
> --------------------------------------------------------------------------
>
>                 Key: TS-849
>                 URL: https://issues.apache.org/jira/browse/TS-849
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 3.1.0, 3.0.1
>            Reporter: Zhao Yongming
>            Assignee: Zhao Yongming
>             Fix For: 3.1.1
>
>
> I am wondering how many config items from records have the same situation?
> {code}
> [root@cache164 trafficserver]# traffic_line -s proxy.config.http.slow.log.threshold -v 30
> Layout configuration
>           --prefix = '/usr'
>      --exec_prefix = '/usr'
>           --bindir = '/usr/bin'
>          --sbindir = '/usr/sbin'
>       --sysconfdir = '/etc/trafficserver'
>          --datadir = '/usr/share/trafficserver'
>       --includedir = '/usr/include/trafficserver'
>           --libdir = '/usr/lib64/trafficserver'
>       --libexecdir = '/usr/lib64/trafficserver/plugins'
>    --localstatedir = '/var/trafficserver'
>       --runtimedir = '/var/run/trafficserver'
>           --logdir = '/var/log/trafficserver'
>           --mandir = '/usr/share/man'
>          --infodir = '/usr/share/info'
>         --cachedir = '/var/cache/trafficserver'
> traffic_line: Only configuration vars can be set
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira