You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/20 13:21:49 UTC
[GitHub] [skywalking] songzhendong opened a new pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
songzhendong opened a new pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137
Add Nacos back into SkyWalking as an option(nacos-1.3.1)，Local compilation passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `44.59%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 44.59% 0.00% -44.60%
============================================
Files 761 156 -605
Lines 18969 3896 -15073
Branches 1873 470 -1403
============================================
- Hits 8459 0 -8459
+ Misses 9767 3896 -5871
+ Partials 743 0 -743
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [731 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `21.47%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
=============================================
- Coverage 52.92% 31.45% -21.48%
+ Complexity 2996 1795 -1201
=============================================
Files 785 757 -28
Lines 19675 18963 -712
Branches 1930 1851 -79
=============================================
- Hits 10413 5964 -4449
- Misses 8402 12551 +4149
+ Partials 860 448 -412
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [271 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **increase** coverage by `53.06%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
=============================================
+ Coverage 0.00% 53.06% +53.06%
- Complexity 0 3001 +3001
=============================================
Files 153 1431 +1278
Lines 3871 31005 +27134
Branches 458 3435 +2977
=============================================
+ Hits 0 16452 +16452
- Misses 3871 13746 +9875
- Partials 0 807 +807
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...2/x/async/RingBufferLogEventMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2c0ai0yLngtYWN0aXZhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vdG9vbGtpdC9hY3RpdmF0aW9uL2xvZy9sb2c0ai92Mi94L2FzeW5jL1JpbmdCdWZmZXJMb2dFdmVudE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.66% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| ... and [1410 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.86%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.16% -0.87%
+ Complexity 2996 2935 -61
============================================
Files 1425 1430 +5
Lines 30878 30952 +74
Branches 3427 3436 +9
============================================
- Hits 16373 16146 -227
- Misses 13701 13999 +298
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 52.92% 53.06% +0.13%
- Complexity 2996 3001 +5
============================================
Files 785 1431 +646
Lines 19675 31004 +11329
Branches 1930 3435 +1505
============================================
+ Hits 10413 16452 +6039
- Misses 8402 13745 +5343
+ Partials 860 807 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [977 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `8.92%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.04% 44.11% -8.93%
+ Complexity 2993 2591 -402
============================================
Files 1424 774 -650
Lines 30860 19386 -11474
Branches 3424 1898 -1526
============================================
- Hits 16371 8553 -7818
+ Misses 13684 10097 -3587
+ Partials 805 736 -69
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1025 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `53.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.11% 0.00% -53.12%
============================================
Files 780 164 -616
Lines 19506 4046 -15460
Branches 1916 485 -1431
============================================
- Hits 10360 0 -10360
+ Misses 8290 4046 -4244
+ Partials 856 0 -856
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [746 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `2.66%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.04% 50.38% -2.67%
+ Complexity 2995 2896 -99
============================================
Files 1424 781 -643
Lines 30864 19583 -11281
Branches 3424 1923 -1501
============================================
- Hits 16371 9866 -6505
+ Misses 13688 8899 -4789
- Partials 805 818 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [994 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 52.90% -0.02%
- Complexity 2996 3001 +5
============================================
Files 785 787 +2
Lines 19675 19700 +25
Branches 1930 1923 -7
============================================
+ Hits 10413 10423 +10
- Misses 8402 8417 +15
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <0.00%> (-2.61%)` | `25.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | | | |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.94%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.07% -0.95%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 31003 +125
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14050 +349
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.87%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.15% -0.88%
+ Complexity 2996 2935 -61
============================================
Files 1425 1430 +5
Lines 30878 30958 +80
Branches 3427 3436 +9
============================================
- Hits 16373 16146 -227
- Misses 13701 14005 +304
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 53.03% 53.05% +0.01%
+ Complexity 2998 2996 -2
============================================
Files 1437 1443 +6
Lines 30867 30982 +115
Branches 3429 3437 +8
============================================
+ Hits 16371 16437 +66
- Misses 13694 13735 +41
- Partials 802 810 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.42% <0.00%> (-3.74%)` | `13.00% <0.00%> (ø%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 52.90% -0.02%
- Complexity 2996 3001 +5
============================================
Files 785 787 +2
Lines 19675 19700 +25
Branches 1930 1923 -7
============================================
+ Hits 10413 10423 +10
- Misses 8402 8417 +15
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <0.00%> (-2.61%)` | `25.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | | | |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.94%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.07% -0.95%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 31003 +125
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14050 +349
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `1.32%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.12% 51.79% -1.33%
+ Complexity 2989 2966 -23
============================================
Files 780 788 +8
Lines 19506 19696 +190
Branches 1916 1936 +20
============================================
- Hits 10362 10202 -160
- Misses 8288 8656 +368
+ Partials 856 838 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [23 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 52.90% -0.02%
- Complexity 2996 3001 +5
============================================
Files 785 787 +2
Lines 19675 19700 +25
Branches 1930 1923 -7
============================================
+ Hits 10413 10423 +10
- Misses 8402 8417 +15
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <0.00%> (-2.61%)` | `25.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | | | |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `2.57%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 50.35% -2.58%
+ Complexity 2996 2893 -103
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 9866 -547
- Misses 8402 8907 +505
+ Partials 860 820 -40
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [41 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `2.42%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.04% 50.62% -2.43%
+ Complexity 2995 2911 -84
============================================
Files 1424 781 -643
Lines 30864 19583 -11281
Branches 3424 1923 -1501
============================================
- Hits 16371 9913 -6458
+ Misses 13688 8849 -4839
- Partials 805 821 +16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [993 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@cff36b6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
=========================================
Coverage ? 53.06%
Complexity ? 3001
=========================================
Files ? 1431
Lines ? 31005
Branches ? 3435
=========================================
Hits ? 16452
Misses ? 13746
Partials ? 807
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.87%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.15% -0.88%
+ Complexity 2996 2935 -61
============================================
Files 1425 1430 +5
Lines 30878 30958 +80
Branches 3427 3436 +9
============================================
- Hits 16373 16146 -227
- Misses 13701 14005 +304
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.08% -0.94%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 30997 +119
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14044 +343
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 53.04% 53.05% +0.01%
+ Complexity 2999 2996 -3
============================================
Files 1437 1443 +6
Lines 30867 30982 +115
Branches 3429 3437 +8
============================================
+ Hits 16372 16437 +65
- Misses 13693 13735 +42
- Partials 802 810 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh) | `69.23% <0.00%> (-7.70%)` | `2.00% <0.00%> (-1.00%)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.42% <0.00%> (-3.74%)` | `13.00% <0.00%> (ø%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `0.52%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.12% 52.59% -0.53%
- Complexity 2989 2990 +1
============================================
Files 780 788 +8
Lines 19506 19706 +200
Branches 1916 1937 +21
============================================
+ Hits 10362 10365 +3
- Misses 8288 8486 +198
+ Partials 856 855 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
| [...p/server/storage/plugin/influxdb/InfluxClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhDbGllbnQuamF2YQ==) | `58.82% <0.00%> (-3.93%)` | `13.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `1.63%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 51.29% -1.64%
+ Complexity 2996 2933 -63
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 10050 -363
- Misses 8402 8708 +306
+ Partials 860 835 -25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.86%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.16% -0.87%
+ Complexity 2996 2935 -61
============================================
Files 1425 1430 +5
Lines 30878 30952 +74
Branches 3427 3436 +9
============================================
- Hits 16373 16146 -227
- Misses 13701 13999 +298
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661871839
@KomachiSion I am going to merge this, once the CI passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.86%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.16% -0.87%
+ Complexity 2996 2935 -61
============================================
Files 1425 1430 +5
Lines 30878 30954 +76
Branches 3427 3436 +9
============================================
- Hits 16373 16146 -227
- Misses 13701 14001 +300
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [30 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7be9f078d9264919eb1158e31c39fb2c5c3fdd0d&el=desc) will **decrease** coverage by `1.52%`.
> The diff coverage is `61.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.60% 52.07% -1.53%
+ Complexity 2966 2935 -31
============================================
Files 759 1431 +672
Lines 19132 31003 +11871
Branches 1874 3437 +1563
============================================
+ Hits 10255 16146 +5891
- Misses 8031 14050 +6019
+ Partials 846 807 -39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `3.44% <3.44%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==) | `55.55% <55.55%> (ø)` | `2.00 <2.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `85.71% <85.71%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [999 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `0.42%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.59% -0.43%
+ Complexity 2998 2990 -8
============================================
Files 1437 788 -649
Lines 30867 19706 -11161
Branches 3429 1937 -1492
============================================
- Hits 16368 10365 -6003
+ Misses 13696 8486 -5210
- Partials 803 855 +52
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [993 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `1.70%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 51.32% -1.71%
+ Complexity 2996 2935 -61
============================================
Files 1425 782 -643
Lines 30878 19633 -11245
Branches 3427 1928 -1499
============================================
- Hits 16373 10076 -6297
+ Misses 13701 8719 -4982
- Partials 804 838 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [989 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 52.92% 53.05% +0.13%
+ Complexity 2996 2994 -2
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 10396 -17
+ Misses 8402 8339 -63
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <0.00%> (-2.61%)` | `25.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 53.04% 53.05% +0.01%
+ Complexity 2999 2996 -3
============================================
Files 1437 1443 +6
Lines 30867 30982 +115
Branches 3429 3437 +8
============================================
+ Hits 16372 16437 +65
- Misses 13693 13735 +42
- Partials 802 810 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh) | `69.23% <0.00%> (-7.70%)` | `2.00% <0.00%> (-1.00%)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.42% <0.00%> (-3.74%)` | `13.00% <0.00%> (ø%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `1.47%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 51.45% -1.48%
+ Complexity 2996 2941 -55
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 10081 -332
- Misses 8402 8670 +268
+ Partials 860 842 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [30 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `1.68%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 51.23% -1.69%
+ Complexity 2996 2932 -64
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 10039 -374
- Misses 8402 8719 +317
+ Partials 860 835 -25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `5.54%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.04% 47.49% -5.55%
+ Complexity 2995 2759 -236
============================================
Files 1424 781 -643
Lines 30864 19583 -11281
Branches 3424 1923 -1501
============================================
- Hits 16371 9301 -7070
+ Misses 13688 9515 -4173
+ Partials 805 767 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1005 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `3.10%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.12% 50.02% -3.11%
+ Complexity 2989 2898 -91
============================================
Files 780 788 +8
Lines 19506 19696 +190
Branches 1916 1936 +20
============================================
- Hits 10362 9852 -510
- Misses 8288 9024 +736
+ Partials 856 820 -36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [38 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 52.92% 53.06% +0.13%
- Complexity 2996 3001 +5
============================================
Files 785 1431 +646
Lines 19675 31005 +11330
Branches 1930 3435 +1505
============================================
+ Hits 10413 16452 +6039
- Misses 8402 13746 +5344
+ Partials 860 807 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [977 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.08% -0.94%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 30997 +119
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14044 +343
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 53.04% 53.05% +0.01%
+ Complexity 2999 2996 -3
============================================
Files 1437 1443 +6
Lines 30867 30982 +115
Branches 3429 3437 +8
============================================
+ Hits 16372 16437 +65
- Misses 13693 13735 +42
- Partials 802 810 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh) | `69.23% <0.00%> (-7.70%)` | `2.00% <0.00%> (-1.00%)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.42% <0.00%> (-3.74%)` | `13.00% <0.00%> (ø%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.17% 52.07% -0.10%
+ Complexity 2957 2935 -22
============================================
Files 780 1431 +651
Lines 19506 31003 +11497
Branches 1916 3437 +1521
============================================
+ Hits 10177 16146 +5969
- Misses 8482 14050 +5568
+ Partials 847 807 -40
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [991 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 52.92% 53.03% +0.11%
- Complexity 2996 3001 +5
============================================
Files 785 786 +1
Lines 19675 19653 -22
Branches 1930 1922 -8
============================================
+ Hits 10413 10423 +10
+ Misses 8402 8370 -32
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <0.00%> (-2.61%)` | `25.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [13 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.08% -0.94%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 30997 +119
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14044 +343
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7be9f078d9264919eb1158e31c39fb2c5c3fdd0d&el=desc) will **decrease** coverage by `0.53%`.
> The diff coverage is `61.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.60% 53.06% -0.54%
- Complexity 2966 3001 +35
============================================
Files 759 1431 +672
Lines 19132 31005 +11873
Branches 1874 3435 +1561
============================================
+ Hits 10255 16452 +6197
- Misses 8031 13746 +5715
+ Partials 846 807 -39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `3.44% <3.44%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==) | `55.55% <55.55%> (ø)` | `2.00 <2.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `85.71% <85.71%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [997 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **increase** coverage by `52.07%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
=============================================
+ Coverage 0.00% 52.07% +52.07%
- Complexity 0 2935 +2935
=============================================
Files 153 1431 +1278
Lines 3798 31003 +27205
Branches 449 3437 +2988
=============================================
+ Hits 0 16146 +16146
- Misses 3798 14050 +10252
- Partials 0 807 +807
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../oap/server/core/query/input/DashboardSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvaW5wdXQvRGFzaGJvYXJkU2V0dGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `39.28% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
| [...king/oap/query/graphql/resolver/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL01ldGFkYXRhUXVlcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...pm/plugin/jdbc/connectionurl/parser/URLParser.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vamRiYy1jb21tb25zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vamRiYy9jb25uZWN0aW9udXJsL3BhcnNlci9VUkxQYXJzZXIuamF2YQ==) | `76.92% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [1409 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.09% 53.05% -0.05%
+ Complexity 3001 2996 -5
============================================
Files 1437 1443 +6
Lines 30867 30982 +115
Branches 3429 3437 +8
============================================
+ Hits 16389 16437 +48
- Misses 13676 13735 +59
- Partials 802 810 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh) | `69.23% <0.00%> (-7.70%)` | `2.00% <0.00%> (-1.00%)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.42% <0.00%> (-3.74%)` | `13.00% <0.00%> (ø%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 53.03% 53.05% +0.01%
+ Complexity 2998 2996 -2
============================================
Files 1437 1443 +6
Lines 30867 30982 +115
Branches 3429 3437 +8
============================================
+ Hits 16371 16437 +66
- Misses 13694 13735 +41
- Partials 802 810 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.42% <0.00%> (-3.74%)` | `13.00% <0.00%> (ø%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `0.23%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 52.68% -0.24%
- Complexity 2996 3001 +5
============================================
Files 785 789 +4
Lines 19675 19782 +107
Branches 1930 1940 +10
============================================
+ Hits 10413 10423 +10
- Misses 8402 8499 +97
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <0.00%> (-2.61%)` | `25.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | | | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `1.70%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 51.32% -1.71%
+ Complexity 2996 2935 -61
============================================
Files 1425 782 -643
Lines 30878 19633 -11245
Branches 3427 1928 -1499
============================================
- Hits 16373 10076 -6297
+ Misses 13701 8719 -4982
- Partials 804 838 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [989 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `5.44%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 47.47% -5.45%
+ Complexity 2996 2757 -239
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 9302 -1111
- Misses 8402 9521 +1119
+ Partials 860 770 -90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [62 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.08% -0.94%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 30997 +119
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14044 +343
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.94%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.07% -0.95%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 31003 +125
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14050 +349
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `9.16%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.12% 43.95% -9.17%
+ Complexity 2989 2564 -425
============================================
Files 780 770 -10
Lines 19506 19239 -267
Branches 1916 1900 -16
============================================
- Hits 10362 8456 -1906
- Misses 8288 10070 +1782
+ Partials 856 713 -143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **increase** coverage by `52.07%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
=============================================
+ Coverage 0.00% 52.07% +52.07%
- Complexity 0 2935 +2935
=============================================
Files 154 1431 +1277
Lines 3807 31003 +27196
Branches 450 3437 +2987
=============================================
+ Hits 0 16146 +16146
- Misses 3807 14050 +10243
- Partials 0 807 +807
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../oap/server/core/query/input/DashboardSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvaW5wdXQvRGFzaGJvYXJkU2V0dGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `39.28% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
| [...king/oap/query/graphql/resolver/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL01ldGFkYXRhUXVlcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [1409 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.08% -0.94%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 30997 +119
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14044 +343
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `2.40%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 50.62% -2.41%
+ Complexity 2996 2911 -85
============================================
Files 1425 781 -644
Lines 30878 19583 -11295
Branches 3427 1923 -1504
============================================
- Hits 16373 9913 -6460
+ Misses 13701 8849 -4852
- Partials 804 821 +17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [989 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 52.92% 53.06% +0.13%
- Complexity 2996 3001 +5
============================================
Files 785 1431 +646
Lines 19675 31005 +11330
Branches 1930 3435 +1505
============================================
+ Hits 10413 16452 +6039
- Misses 8402 13746 +5344
+ Partials 860 807 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [977 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `52.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.17% 0.00% -52.18%
============================================
Files 780 164 -616
Lines 19506 4046 -15460
Branches 1916 485 -1431
============================================
- Hits 10177 0 -10177
+ Misses 8482 4046 -4436
+ Partials 847 0 -847
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [746 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.08% -0.94%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 30997 +119
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14044 +343
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `2.40%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 50.62% -2.41%
+ Complexity 2995 2911 -84
============================================
Files 1425 781 -644
Lines 30878 19583 -11295
Branches 3427 1923 -1504
============================================
- Hits 16372 9913 -6459
+ Misses 13701 8849 -4852
- Partials 805 821 +16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [990 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 52.92% 53.05% +0.13%
+ Complexity 2996 2994 -2
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 10396 -17
+ Misses 8402 8339 -63
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <0.00%> (-2.61%)` | `25.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 52.92% 53.03% +0.11%
- Complexity 2996 3001 +5
============================================
Files 785 786 +1
Lines 19675 19653 -22
Branches 1930 1922 -8
============================================
+ Hits 10413 10423 +10
+ Misses 8402 8370 -32
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <0.00%> (-2.61%)` | `25.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [13 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.90% 52.59% -0.31%
- Complexity 2989 2990 +1
============================================
Files 1437 788 -649
Lines 30863 19706 -11157
Branches 3429 1937 -1492
============================================
- Hits 16329 10365 -5964
+ Misses 13730 8486 -5244
- Partials 804 855 +51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [994 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **increase** coverage by `20.32%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
=============================================
+ Coverage 32.74% 53.06% +20.32%
- Complexity 1867 3001 +1134
=============================================
Files 759 1431 +672
Lines 18985 31005 +12020
Branches 1854 3435 +1581
=============================================
+ Hits 6216 16452 +10236
- Misses 12286 13746 +1460
- Partials 483 807 +324
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `84.61% <0.00%> (-15.39%)` | `4.00% <0.00%> (ø%)` | |
| ... and [1087 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.03% 52.94% -0.09%
+ Complexity 2998 2992 -6
============================================
Files 1437 1443 +6
Lines 30867 30982 +115
Branches 3429 3437 +8
============================================
+ Hits 16369 16404 +35
- Misses 13696 13768 +72
- Partials 802 810 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `57.66% <0.00%> (-4.38%)` | `17.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.64% <0.00%> (-4.30%)` | `25.00% <0.00%> (-1.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 52.92% 53.06% +0.13%
- Complexity 2996 3001 +5
============================================
Files 785 1431 +646
Lines 19675 31004 +11329
Branches 1930 3435 +1505
============================================
+ Hits 10413 16452 +6039
- Misses 8402 13745 +5343
+ Partials 860 807 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [977 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
+ Coverage 52.92% 53.06% +0.13%
- Complexity 2996 3001 +5
============================================
Files 785 1431 +646
Lines 19675 31005 +11330
Branches 1930 3435 +1505
============================================
+ Hits 10413 16452 +6039
- Misses 8402 13746 +5344
+ Partials 860 807 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [977 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.08% -0.94%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 30997 +119
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14044 +343
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `8.92%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.04% 44.11% -8.93%
+ Complexity 2995 2591 -404
============================================
Files 1424 774 -650
Lines 30860 19386 -11474
Branches 3424 1898 -1526
============================================
- Hits 16371 8553 -7818
+ Misses 13684 10097 -3587
+ Partials 805 736 -69
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1025 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `11.84%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
=============================================
- Coverage 52.66% 40.81% -11.85%
+ Complexity 2958 2376 -582
=============================================
Files 1424 753 -671
Lines 30859 18794 -12065
Branches 3424 1849 -1575
=============================================
- Hits 16251 7671 -8580
+ Misses 13803 10441 -3362
+ Partials 805 682 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1044 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `2.50%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 50.51% -2.51%
+ Complexity 2996 2911 -85
============================================
Files 1425 782 -643
Lines 30878 19623 -11255
Branches 3427 1927 -1500
============================================
- Hits 16373 9913 -6460
+ Misses 13701 8889 -4812
- Partials 804 821 +17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [989 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `0.39%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.62% -0.40%
+ Complexity 2998 2992 -6
============================================
Files 1437 788 -649
Lines 30867 19706 -11161
Branches 3429 1937 -1492
============================================
- Hits 16368 10371 -5997
+ Misses 13696 8479 -5217
- Partials 803 856 +53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [993 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7be9f078d9264919eb1158e31c39fb2c5c3fdd0d&el=desc) will **decrease** coverage by `0.53%`.
> The diff coverage is `61.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.60% 53.06% -0.54%
- Complexity 2966 3001 +35
============================================
Files 759 1431 +672
Lines 19132 31005 +11873
Branches 1874 3435 +1561
============================================
+ Hits 10255 16452 +6197
- Misses 8031 13746 +5715
+ Partials 846 807 -39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `3.44% <3.44%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==) | `55.55% <55.55%> (ø)` | `2.00 <2.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `85.71% <85.71%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [997 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `19.20%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
=============================================
- Coverage 52.92% 33.71% -19.21%
+ Complexity 2996 1945 -1051
=============================================
Files 785 775 -10
Lines 19675 19423 -252
Branches 1930 1887 -43
=============================================
- Hits 10413 6549 -3864
- Misses 8402 12382 +3980
+ Partials 860 492 -368
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [244 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `1.70%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 51.21% -1.71%
+ Complexity 2996 2931 -65
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 10035 -378
- Misses 8402 8723 +321
+ Partials 860 835 -25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.02% 52.08% -0.94%
+ Complexity 2996 2935 -61
============================================
Files 1425 1431 +6
Lines 30878 30997 +119
Branches 3427 3437 +10
============================================
- Hits 16373 16146 -227
- Misses 13701 14044 +343
- Partials 804 807 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.03% 52.94% -0.09%
+ Complexity 2998 2992 -6
============================================
Files 1437 1443 +6
Lines 30867 30982 +115
Branches 3429 3437 +8
============================================
+ Hits 16369 16404 +35
- Misses 13696 13768 +72
- Partials 802 810 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `57.66% <0.00%> (-4.38%)` | `17.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `53.64% <0.00%> (-4.30%)` | `25.00% <0.00%> (-1.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cff36b63bcba2a16b7f525f40dc18f17bf662fe2&el=desc) will **decrease** coverage by `2.42%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.04% 50.62% -2.43%
+ Complexity 2995 2911 -84
============================================
Files 1424 781 -643
Lines 30865 19583 -11282
Branches 3424 1923 -1501
============================================
- Hits 16371 9913 -6458
+ Misses 13689 8849 -4840
- Partials 805 821 +16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [992 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [cff36b6...271370e](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `1.63%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 51.29% -1.64%
+ Complexity 2996 2933 -63
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 10050 -363
- Misses 8402 8708 +306
+ Partials 860 835 -25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `1.63%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 51.29% -1.64%
+ Complexity 2996 2933 -63
============================================
Files 785 781 -4
Lines 19675 19593 -82
Branches 1930 1915 -15
============================================
- Hits 10413 10050 -363
- Misses 8402 8708 +306
+ Partials 860 835 -25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `13.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 52.92% 52.89% -0.03%
+ Complexity 2996 2994 -2
============================================
Files 785 786 +1
Lines 19675 19653 -22
Branches 1930 1922 -8
============================================
- Hits 10413 10396 -17
+ Misses 8402 8399 -3
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.08% <0.00%> (-2.61%)` | `25.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| ... and [14 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [e0325a4...bd8a7fc](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5137: Add Nacos back into SkyWalking as an option(nacos-1.3.1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5137:
URL: https://github.com/apache/skywalking/pull/5137#issuecomment-661088784
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=h1) Report
> Merging [#5137](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/20b1b51798f8fbbbe043aa8ee2951cc1dbcd16bb&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5137 +/- ##
============================================
- Coverage 53.09% 53.05% -0.05%
+ Complexity 3001 2996 -5
============================================
Files 1437 1443 +6
Lines 30867 30982 +115
Branches 3429 3437 +8
============================================
+ Hits 16389 16437 +48
- Misses 13676 13735 +59
- Partials 802 810 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh) | `69.23% <0.00%> (-7.70%)` | `2.00% <0.00%> (-1.00%)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `65.42% <0.00%> (-3.74%)` | `13.00% <0.00%> (ø%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5137/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=footer). Last update [20b1b51...b953294](https://codecov.io/gh/apache/skywalking/pull/5137?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org