You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vesense <gi...@git.apache.org> on 2015/09/18 09:21:26 UTC
[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/744
[STORM-1053] Correct storm-kafka readme file because of using new kafka-clients api
correct readme file: new producer link & configs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm patch-7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/744.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #744
----
commit be7f2ad1d9b6be1a92fb2a8775822b5752703c89
Author: Xin Wang <be...@163.com>
Date: 2015-09-18T07:19:44Z
correct storm-kafka readme file
correct readme file: link & configs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/744#issuecomment-144543208
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/744
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/744#issuecomment-144542259
Looks good to me. The only nit is the title of this JIRA: new Kafka Producer API rather than kafka-client.
the new Kafka Clients API is still in the process in STORM-822.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---