You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/02 05:20:43 UTC
[GitHub] [beam] rmannibucau opened a new pull request #11886: [BEAM-8647] delete .mailmap
rmannibucau opened a new pull request #11886:
URL: https://github.com/apache/beam/pull/11886
side note: if you really need this file (like for the website) maybe use a private asf repo and ensure it is not in a public deliverable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-687650303
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-649102442
This file is very useful for producing the release notes and integrating with various git stats tools. It is just a reformatting of information available in the git log. I will read the linked thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-649105139
FWIW I am not sure everyone on this PR is familiar with the file. It is a config file to help git pretty print the log.
See the "List Of Contributors" on https://beam.apache.org/blog/beam-2.22.0/. Without this file, the list will have duplicate entries like `Kenneth Knowles <ke...@apache.org>` and `Kenn Knowles <kl...@google.com>` and possibly some that are just `klk@google.com` etc. The file is a hint to git to de-dupe these when printing the log.
If anything, using GitHub APIs is worse, because it associates actual registered accounts that are connected to other information. All this file does is associate strings that already exist in the log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rmannibucau commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-638200730
@iemejia yes and no, 1. it is quite clear in europe and affects US based entities + 2 ASF can't justify to need this file (side note: it can trivially be replaced by GH API nowdays).
Lastly the overall PR was "by fun" and rather -1 (https://github.com/apache/beam/pull/1925) than +1 so I think it confirms it is just not used and it does not hurt to drop so no real need to discuss for year on that. If a better mapping is needed I suspect gh API can be used, a small script can be added to beam and .mailmap can be generated locally and added to .gitignore instead of explicitly exposing it (to scrappers/crawlers).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rmannibucau commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-646449872
@ajamato I just need somebody hitting merge button ;). The side note to @aaltay comment is that it is easier to bulk clone that to bulk GET (api) due to the rate limits, so often scrappers use clone rather than the API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ajamato commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
ajamato commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-646364256
@rmannibucau Do you need more help to move this forward? Or did you find an alternative way, if so can this PR be closed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-638194592
For extra info the discussion on `privacy-discuss@` on how to handle these cases (conclusion nothing is clear and we do not have real ASF recommendations yet)
https://lists.apache.org/thread.html/ra3dc372d3bcbcfa675e1e68867fceebc00aec0562d4c787a36f42562%40%3Cprivacy-discuss.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rmannibucau commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-711729766
up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-683257080
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-650410893
I am not arguing that "it is public for GitHub so it can be made public in the git repo". This file is not based on any GitHub data. It is based entirely on the git history itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-637637206
R: @iemejia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-649108755
I see now that the thread link that Ismaël provided is the root discussion that we should follow to resolve this. I want to emphasize that also individual requests to remove information from this file I would of course support. Anyone removing their information should be warned that it does not protect the information or make it less public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-637643375
I think we are not using this file any more so ok to remove can you confirm @kennknowles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rmannibucau commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-688043183
Can it be done reopen and fixed please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] stale[bot] closed pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #11886:
URL: https://github.com/apache/beam/pull/11886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles edited a comment on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
kennknowles edited a comment on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-649105139
FWIW I am not sure everyone on this PR is familiar with the file. It is a config file to help git pretty print the log.
See the "List Of Contributors" on https://beam.apache.org/blog/beam-2.22.0/. Without this file, the list will have duplicate entries like `Kenneth Knowles <ke...@apache.org>` and `Kenn Knowles <kl...@google.com>` and possibly some that are just `klk@google.com` etc. The file is a hint to git to de-dupe these when printing the log.
If anything, using GitHub APIs is worse, because it associates actual registered accounts that are connected to other information. All this file does is associate strings that already exist in the log. But, as noted, that information is also all public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rmannibucau commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-649238480
@kennknowles the argument that it is public for github so it can be made public in the git repo is wrong, when you have a github account you ack or not that and you can request to drop it due to GPDR so this file should be regenerated each time github changes anything (I assume once a day would work). Also, project must request authorization to use these data there and track ack+enable to change it to be legal. AFAIK none of both is done (right?) so this workflow does not work and can trivially be replaced by a github request - with a falling back on "unknown" or anything you like when the email is no more available- companies can request github to become GPDR compliant which means data can be missing. You can also reverse the pattern and just list duplicates instead and handle the name in a case insensitive manner maybe? This reduces the number of entries a lot AFAIK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-642987787
I do not believe we are using this file. I could not find a reference to it in any process documents. I agree that, it does not make much sense to keep this information in the repository. Also noting that removing this does not add much to the level of privacy, the same information is already publicly available in git log, or github apis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #11886: [BEAM-8647] delete .mailmap
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-637636230
R: @kennknowles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org