You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2011/09/09 06:57:10 UTC

[jira] [Commented] (THRIFT-1333) Make RWGuard not copyable

    [ https://issues.apache.org/jira/browse/THRIFT-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100981#comment-13100981 ] 

Hudson commented on THRIFT-1333:
--------------------------------

Integrated in Thrift #254 (See [https://builds.apache.org/job/Thrift/254/])
    THRIFT-1333: Make RWGuard not copyable
Client: cpp
Patch: Dave Watson

Copying would cause contained mutex to unlock twice, changing to noncopyable.

jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1166996
Files : 
* /thrift/trunk/lib/cpp/src/concurrency/Mutex.h


>  Make RWGuard not copyable

> ---------------------------
>
>                 Key: THRIFT-1333
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1333
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: 0029-Make-RWGuard-not-copyable.patch
>
>
> From aca289c602251bbfe7f6543ce037ac795be273e0 Mon Sep 17 00:00:00 2001
> From: Jordan DeLong <jd...@fb.com>
> Date: Tue, 20 Apr 2010 19:35:56 +0000
> Subject: [PATCH 29/33] Make RWGuard not copyable
> Summary:
> Copying this class would cause its contained mutex to
> unlock twice.  Mark it noncopyable.
> Test Plan:
> Compiled [internal fb thing].
> Revert Plan:
> OK
> ---
>  lib/cpp/src/concurrency/Mutex.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira