You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhan Reddy <mr...@gmail.com> on 2017/04/03 07:10:15 UTC
Review Request 58135: Workflow should retain job.properties in
submission modal window
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58135/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha.
Bugs: AMBARI-20654
https://issues.apache.org/jira/browse/AMBARI-20654
Repository: ambari
Description
-------
Stored the job.properties on submission and retrieving the values when reopening the modal window
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 5f885e7
contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 15c1fbf
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0da9f71
Diff: https://reviews.apache.org/r/58135/diff/1/
Testing
-------
Manual
Thanks,
Madhan Reddy
Re: Review Request 58135: Workflow should retain job.properties in
submission modal window
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58135/#review170851
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On April 3, 2017, 7:10 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58135/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 7:10 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20654
> https://issues.apache.org/jira/browse/AMBARI-20654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stored the job.properties on submission and retrieving the values when reopening the modal window
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 5f885e7
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 15c1fbf
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0da9f71
>
>
> Diff: https://reviews.apache.org/r/58135/diff/1/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>
Re: Review Request 58135: Workflow should retain job.properties in
submission modal window
Posted by Madhan Reddy <mr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58135/
-----------------------------------------------------------
(Updated April 4, 2017, 6:01 a.m.)
Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha.
Bugs: AMBARI-20654
https://issues.apache.org/jira/browse/AMBARI-20654
Repository: ambari
Description
-------
Stored the job.properties on submission and retrieving the values when reopening the modal window
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 5f885e7
contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 15c1fbf
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0da9f71
Diff: https://reviews.apache.org/r/58135/diff/1/
Testing
-------
Manual
Thanks,
Madhan Reddy
Re: Review Request 58135: Workflow should retain job.properties in
submission modal window
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58135/#review170822
-----------------------------------------------------------
Ship it!
Ship It!
- Padma Priya N
On April 3, 2017, 7:10 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58135/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 7:10 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20654
> https://issues.apache.org/jira/browse/AMBARI-20654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stored the job.properties on submission and retrieving the values when reopening the modal window
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 5f885e7
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 15c1fbf
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0da9f71
>
>
> Diff: https://reviews.apache.org/r/58135/diff/1/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>