You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/11 13:30:48 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1611: libc/stdio: Allocate file_struct dynamically

xiaoxiang781216 edited a comment on pull request #1611:
URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-691096139


   > > I would like to test this in its entirety once it does pass.
   > 
   > @v01d Unfortunately no.
   > 
   > Since we could not get a clean CI pass on it. it should not have been merged.
   
   This PR can't pass CI just because it need work with https://github.com/apache/incubator-nuttx-apps/pull/368. But it is an CI issue, not the PR problem. The community already have an agreement that the reviewer could focus on the change but ignore CI complain before the build system can cover this case. So CI failure isn't a good reason to block PR like this one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org