You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@gmail.com> on 2021/11/01 14:34:26 UTC

[VOTE] Apache OFBiz 18.12.02

This is the vote thread to publish "Apache OFBiz 18.12.02", the second
release from the release18.12 branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/
and are:
* apache-ofbiz-18.12.02.zip
* KEYS: text file with keys
* apache-ofbiz-18.12.02.zip.asc: the detached signature file
* apache-ofbiz-18.12.02.zip.sha512: checksum file

Please download and test the zip file and its signatures (for instructions
on testing the signatures see http://www.apache.org/info/verification.html).

Vote:
[ +1] release as Apache OFBiz 18.12.02
[ -1] do not release

This vote will be open for 5 days.

For more details about this process please refer to
http://www.apache.org/foundation/voting.html

Best Regards,

Jacopo

Re: [VOTE] Apache OFBiz 18.12.02

Posted by Giulio Speri - MpStyle Srl <gi...@mpstyle.it>.
+1

On Mon, Nov 1, 2021, 15:42 Jacopo Cappellato <ja...@gmail.com>
wrote:

> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
> release from the release18.12 branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> and are:
> * apache-ofbiz-18.12.02.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html
> ).
>
> Vote:
> [ +1] release as Apache OFBiz 18.12.02
> [ -1] do not release
>
> This vote will be open for 5 days.
>
> For more details about this process please refer to
> http://www.apache.org/foundation/voting.html
>
> Best Regards,
>
> Jacopo
>

Re: Validating a release with verify-ofbiz-release.sh was: [VOTE] Apache OFBiz 18.12.02

Posted by Giulio Speri - MpStyle Srl <gi...@mpstyle.it>.
Hi Micheal,

I Will use it for sure next time.

Thanks You very much,
Giulio





On Wed, Nov 3, 2021, 15:18 Michael Brohl <mi...@ecomify.de> wrote:

> Hi Giulio, all,
>
> for convenience, I've contributed a verification script for releases
> which will automatically download the release files, validates checksums
> and runs the tests in a single run or several steps.
>
> Please check out verify-ofbiz-release.sh in the ofbiz-tools repository [1]
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> [1] https://gitbox.apache.org/repos/asf/ofbiz-tools.git
>
> Am 03.11.21 um 15:03 schrieb Giulio Speri - MpStyle Srl:
> > Hi everyone,
> >
> > I have to revert my previous +1 (I just tested the checksums, not the
> build
> > and I apologize for that), since the build still fails with the same
> error
> > of 18.12.01.
> >
> > My official vote is now
> >
> > -1
> >
> > Giulio
> >
> > Il giorno mer 3 nov 2021 alle ore 14:21 Wiebke Pätzold <
> > wiebke.paetzold@ecomify.de> ha scritto:
> >
> >> -1 The reason for the new release is a fix for
> >> https://issues.apache.org/jira/browse/OFBIZ-12351, but as far as I can
> >> see the temporary fix is only applied to trunk. So the Release18.12.02
> >> has no changes to Release18.12.01 or am I something missing?
> >>
> >> I also provided a PR for the 18.12 branch with a better fix, since this
> >> one does not depend on jcenter.
> >>
> >> Am 02.11.21 um 08:37 schrieb Jacques Le Roux:
> >>> +1
> >>>
> >>> $ ./verify-ofbiz-release.sh apache-ofbiz-18.12.02.zip
> >>> sha check of file: apache-ofbiz-18.12.02.zip
> >>> Using sha file: apache-ofbiz-18.12.02.zip.sha512
> >>> apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
> >>> 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
> >>> 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> >>> apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
> >>> 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
> >>> 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> >>> sha checksum OK
> >>>
> >>> GPG verification output
> >>> gpg: Signature made Mon Nov  1 15:11:59 2021
> >>> gpg:                using RSA key 7A580908847AF9E0
> >>> gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> >>> <ja...@apache.org>"
> >>>
> >>> Tests are OK but I had to change 38802 to 39676 in
> >>> checkstyle::maxErrors, not sure why. Seems like last time, checkstyle
> >>> disallow building. Seems more an issue on my side, not the same than
> >>> last time. I'll investigate
> >>>
> >>> Jacques
> >>>
> >>> Le 01/11/2021 à 15:34, Jacopo Cappellato a écrit :
> >>>> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
> >>>> release from the release18.12 branch.
> >>>>
> >>>> The release files can be downloaded from here:
> >>>> https://dist.apache.org/repos/dist/dev/ofbiz/
> >>>> and are:
> >>>> * apache-ofbiz-18.12.02.zip
> >>>> * KEYS: text file with keys
> >>>> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> >>>> * apache-ofbiz-18.12.02.zip.sha512: checksum file
> >>>>
> >>>> Please download and test the zip file and its signatures (for
> >>>> instructions
> >>>> on testing the signatures see
> >>>> http://www.apache.org/info/verification.html).
> >>>>
> >>>> Vote:
> >>>> [ +1] release as Apache OFBiz 18.12.02
> >>>> [ -1] do not release
> >>>>
> >>>> This vote will be open for 5 days.
> >>>>
> >>>> For more details about this process please refer to
> >>>> http://www.apache.org/foundation/voting.html
> >>>>
> >>>> Best Regards,
> >>>>
> >>>> Jacopo
> >> --
> >> Wiebke Pätzold
> >> Developer und Consultant
> >>
> >> ecomify GmbH, Gustav-Winkler-Str. 22, 33699 Bielefeld
> >> Fon: +49 521 448157-90 | Fax: +49 521 448157-99 | www.ecomify.de
> >> Court Registration: Amtsgericht Bielefeld, HRB 41683 | CEO: Martin
> Becker,
> >> Michael Brohl
> >>
> >>
>

Validating a release with verify-ofbiz-release.sh was: [VOTE] Apache OFBiz 18.12.02

Posted by Michael Brohl <mi...@ecomify.de>.
Hi Giulio, all,

for convenience, I've contributed a verification script for releases 
which will automatically download the release files, validates checksums 
and runs the tests in a single run or several steps.

Please check out verify-ofbiz-release.sh in the ofbiz-tools repository [1]

Best regards,

Michael Brohl

ecomify GmbH - www.ecomify.de


[1] https://gitbox.apache.org/repos/asf/ofbiz-tools.git

Am 03.11.21 um 15:03 schrieb Giulio Speri - MpStyle Srl:
> Hi everyone,
>
> I have to revert my previous +1 (I just tested the checksums, not the build
> and I apologize for that), since the build still fails with the same error
> of 18.12.01.
>
> My official vote is now
>
> -1
>
> Giulio
>
> Il giorno mer 3 nov 2021 alle ore 14:21 Wiebke Pätzold <
> wiebke.paetzold@ecomify.de> ha scritto:
>
>> -1 The reason for the new release is a fix for
>> https://issues.apache.org/jira/browse/OFBIZ-12351, but as far as I can
>> see the temporary fix is only applied to trunk. So the Release18.12.02
>> has no changes to Release18.12.01 or am I something missing?
>>
>> I also provided a PR for the 18.12 branch with a better fix, since this
>> one does not depend on jcenter.
>>
>> Am 02.11.21 um 08:37 schrieb Jacques Le Roux:
>>> +1
>>>
>>> $ ./verify-ofbiz-release.sh apache-ofbiz-18.12.02.zip
>>> sha check of file: apache-ofbiz-18.12.02.zip
>>> Using sha file: apache-ofbiz-18.12.02.zip.sha512
>>> apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
>>> 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
>>> 2355019F 23E5A33C C968493E 54AF5848 91F406DD
>>> apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
>>> 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
>>> 2355019F 23E5A33C C968493E 54AF5848 91F406DD
>>> sha checksum OK
>>>
>>> GPG verification output
>>> gpg: Signature made Mon Nov  1 15:11:59 2021
>>> gpg:                using RSA key 7A580908847AF9E0
>>> gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
>>> <ja...@apache.org>"
>>>
>>> Tests are OK but I had to change 38802 to 39676 in
>>> checkstyle::maxErrors, not sure why. Seems like last time, checkstyle
>>> disallow building. Seems more an issue on my side, not the same than
>>> last time. I'll investigate
>>>
>>> Jacques
>>>
>>> Le 01/11/2021 à 15:34, Jacopo Cappellato a écrit :
>>>> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
>>>> release from the release18.12 branch.
>>>>
>>>> The release files can be downloaded from here:
>>>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>>> and are:
>>>> * apache-ofbiz-18.12.02.zip
>>>> * KEYS: text file with keys
>>>> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
>>>> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>>>>
>>>> Please download and test the zip file and its signatures (for
>>>> instructions
>>>> on testing the signatures see
>>>> http://www.apache.org/info/verification.html).
>>>>
>>>> Vote:
>>>> [ +1] release as Apache OFBiz 18.12.02
>>>> [ -1] do not release
>>>>
>>>> This vote will be open for 5 days.
>>>>
>>>> For more details about this process please refer to
>>>> http://www.apache.org/foundation/voting.html
>>>>
>>>> Best Regards,
>>>>
>>>> Jacopo
>> --
>> Wiebke Pätzold
>> Developer und Consultant
>>
>> ecomify GmbH, Gustav-Winkler-Str. 22, 33699 Bielefeld
>> Fon: +49 521 448157-90 | Fax: +49 521 448157-99 | www.ecomify.de
>> Court Registration: Amtsgericht Bielefeld, HRB 41683 | CEO: Martin Becker,
>> Michael Brohl
>>
>>

Re: [VOTE] Apache OFBiz 18.12.02

Posted by Giulio Speri - MpStyle Srl <gi...@mpstyle.it>.
Hi everyone,

I have to revert my previous +1 (I just tested the checksums, not the build
and I apologize for that), since the build still fails with the same error
of 18.12.01.

My official vote is now

-1

Giulio

Il giorno mer 3 nov 2021 alle ore 14:21 Wiebke Pätzold <
wiebke.paetzold@ecomify.de> ha scritto:

> -1 The reason for the new release is a fix for
> https://issues.apache.org/jira/browse/OFBIZ-12351, but as far as I can
> see the temporary fix is only applied to trunk. So the Release18.12.02
> has no changes to Release18.12.01 or am I something missing?
>
> I also provided a PR for the 18.12 branch with a better fix, since this
> one does not depend on jcenter.
>
> Am 02.11.21 um 08:37 schrieb Jacques Le Roux:
> > +1
> >
> > $ ./verify-ofbiz-release.sh apache-ofbiz-18.12.02.zip
> > sha check of file: apache-ofbiz-18.12.02.zip
> > Using sha file: apache-ofbiz-18.12.02.zip.sha512
> > apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
> > 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
> > 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> > apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
> > 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
> > 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> > sha checksum OK
> >
> > GPG verification output
> > gpg: Signature made Mon Nov  1 15:11:59 2021
> > gpg:                using RSA key 7A580908847AF9E0
> > gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> > <ja...@apache.org>"
> >
> > Tests are OK but I had to change 38802 to 39676 in
> > checkstyle::maxErrors, not sure why. Seems like last time, checkstyle
> > disallow building. Seems more an issue on my side, not the same than
> > last time. I'll investigate
> >
> > Jacques
> >
> > Le 01/11/2021 à 15:34, Jacopo Cappellato a écrit :
> >> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
> >> release from the release18.12 branch.
> >>
> >> The release files can be downloaded from here:
> >> https://dist.apache.org/repos/dist/dev/ofbiz/
> >> and are:
> >> * apache-ofbiz-18.12.02.zip
> >> * KEYS: text file with keys
> >> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> >> * apache-ofbiz-18.12.02.zip.sha512: checksum file
> >>
> >> Please download and test the zip file and its signatures (for
> >> instructions
> >> on testing the signatures see
> >> http://www.apache.org/info/verification.html).
> >>
> >> Vote:
> >> [ +1] release as Apache OFBiz 18.12.02
> >> [ -1] do not release
> >>
> >> This vote will be open for 5 days.
> >>
> >> For more details about this process please refer to
> >> http://www.apache.org/foundation/voting.html
> >>
> >> Best Regards,
> >>
> >> Jacopo
> >
> --
> Wiebke Pätzold
> Developer und Consultant
>
> ecomify GmbH, Gustav-Winkler-Str. 22, 33699 Bielefeld
> Fon: +49 521 448157-90 | Fax: +49 521 448157-99 | www.ecomify.de
> Court Registration: Amtsgericht Bielefeld, HRB 41683 | CEO: Martin Becker,
> Michael Brohl
>
>

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: [VOTE] Apache OFBiz 18.12.02

Posted by Wiebke Pätzold <wi...@ecomify.de>.
-1 The reason for the new release is a fix for 
https://issues.apache.org/jira/browse/OFBIZ-12351, but as far as I can 
see the temporary fix is only applied to trunk. So the Release18.12.02 
has no changes to Release18.12.01 or am I something missing?

I also provided a PR for the 18.12 branch with a better fix, since this 
one does not depend on jcenter.

Am 02.11.21 um 08:37 schrieb Jacques Le Roux:
> +1
>
> $ ./verify-ofbiz-release.sh apache-ofbiz-18.12.02.zip
> sha check of file: apache-ofbiz-18.12.02.zip
> Using sha file: apache-ofbiz-18.12.02.zip.sha512
> apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2 
> 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F 
> 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2 
> 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F 
> 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> sha checksum OK
>
> GPG verification output
> gpg: Signature made Mon Nov  1 15:11:59 2021
> gpg:                using RSA key 7A580908847AF9E0
> gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) 
> <ja...@apache.org>"
>
> Tests are OK but I had to change 38802 to 39676 in 
> checkstyle::maxErrors, not sure why. Seems like last time, checkstyle 
> disallow building. Seems more an issue on my side, not the same than 
> last time. I'll investigate
>
> Jacques
>
> Le 01/11/2021 à 15:34, Jacopo Cappellato a écrit :
>> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
>> release from the release18.12 branch.
>>
>> The release files can be downloaded from here:
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>> and are:
>> * apache-ofbiz-18.12.02.zip
>> * KEYS: text file with keys
>> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
>> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>>
>> Please download and test the zip file and its signatures (for 
>> instructions
>> on testing the signatures see 
>> http://www.apache.org/info/verification.html).
>>
>> Vote:
>> [ +1] release as Apache OFBiz 18.12.02
>> [ -1] do not release
>>
>> This vote will be open for 5 days.
>>
>> For more details about this process please refer to
>> http://www.apache.org/foundation/voting.html
>>
>> Best Regards,
>>
>> Jacopo
>
-- 
Wiebke Pätzold
Developer und Consultant

ecomify GmbH, Gustav-Winkler-Str. 22, 33699 Bielefeld
Fon: +49 521 448157-90 | Fax: +49 521 448157-99 | www.ecomify.de
Court Registration: Amtsgericht Bielefeld, HRB 41683 | CEO: Martin Becker, Michael Brohl


Re: [VOTE] Apache OFBiz 18.12.02

Posted by Jacques Le Roux <ja...@les7arts.com>.
+1

$ ./verify-ofbiz-release.sh apache-ofbiz-18.12.02.zip
sha check of file: apache-ofbiz-18.12.02.zip
Using sha file: apache-ofbiz-18.12.02.zip.sha512
apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F 2355019F 23E5A33C 
C968493E 54AF5848 91F406DD
apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F 2355019F 23E5A33C 
C968493E 54AF5848 91F406DD
sha checksum OK

GPG verification output
gpg: Signature made Mon Nov  1 15:11:59 2021
gpg:                using RSA key 7A580908847AF9E0
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) <ja...@apache.org>"

Tests are OK but I had to change 38802 to 39676 in checkstyle::maxErrors, not sure why. Seems like last time, checkstyle disallow building. Seems more 
an issue on my side, not the same than last time. I'll investigate

Jacques

Le 01/11/2021 à 15:34, Jacopo Cappellato a écrit :
> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
> release from the release18.12 branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> and are:
> * apache-ofbiz-18.12.02.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 18.12.02
> [ -1] do not release
>
> This vote will be open for 5 days.
>
> For more details about this process please refer to
> http://www.apache.org/foundation/voting.html
>
> Best Regards,
>
> Jacopo


Re: [VOTE] Apache OFBiz 18.12.02

Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes, TIA Jacopo

Le 05/11/2021 à 10:38, Jacopo Cappellato a écrit :
> Let's cancel this vote (for obvious reasons)!
> Should I start the preparation of the new tentative release files today and
> then start a new vote?
>
> Jacopo
>
> On Mon, Nov 1, 2021 at 3:34 PM Jacopo Cappellato <
> jacopo.cappellato@gmail.com> wrote:
>
>> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
>> release from the release18.12 branch.
>>
>> The release files can be downloaded from here:
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>> and are:
>> * apache-ofbiz-18.12.02.zip
>> * KEYS: text file with keys
>> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
>> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>>
>> Please download and test the zip file and its signatures (for instructions
>> on testing the signatures see http://www.apache.org/info/verification.html
>> ).
>>
>> Vote:
>> [ +1] release as Apache OFBiz 18.12.02
>> [ -1] do not release
>>
>> This vote will be open for 5 days.
>>
>> For more details about this process please refer to
>> http://www.apache.org/foundation/voting.html
>>
>> Best Regards,
>>
>> Jacopo
>>

Re: [VOTE] Apache OFBiz 18.12.02

Posted by Jacopo Cappellato <ja...@gmail.com>.
Let's cancel this vote (for obvious reasons)!
Should I start the preparation of the new tentative release files today and
then start a new vote?

Jacopo

On Mon, Nov 1, 2021 at 3:34 PM Jacopo Cappellato <
jacopo.cappellato@gmail.com> wrote:

> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
> release from the release18.12 branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> and are:
> * apache-ofbiz-18.12.02.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html
> ).
>
> Vote:
> [ +1] release as Apache OFBiz 18.12.02
> [ -1] do not release
>
> This vote will be open for 5 days.
>
> For more details about this process please refer to
> http://www.apache.org/foundation/voting.html
>
> Best Regards,
>
> Jacopo
>

Re: [VOTE] Apache OFBiz 18.12.02

Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 03/11/2021 à 17:19, Jacques Le Roux a écrit :
> Le 03/11/2021 à 16:38, Jacques Le Roux a écrit :
>> Note that, despite not having applied the patch, R18 works using "gradlew cleanAll loadAll ofbiz" 
> Ah forgot: I did not clean the Gradle cache

Just to be clear. it was not needed to clear the Gradle cache because another lib is used to replace syndication.

To prove it was not needed to clear the Gradle cache; I nevertheless cleared all syndication stuff from the Gradle cache and tested again with success 
Wiebke's solution.

I believe her solution definitely clears the case. Even if it seems no changes were needed in R18 as our initial tests on 18.12.2 proved.

So +1 for Wiebke's solution to be included not only in trunk but also in R18 before releasing 18.12.2  (I hope it's totally clear now :)

Jacques



Re: [VOTE] Apache OFBiz 18.12.02

Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 03/11/2021 à 16:38, Jacques Le Roux a écrit :
> Note that, despite not having applied the patch, R18 works using "gradlew cleanAll loadAll ofbiz" 
Ah forgot: I did not clean the Gradle cache


Re: [VOTE] Apache OFBiz 18.12.02

Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 03/11/2021 à 16:05, Jacques Le Roux a écrit :
> Not sure it's related (I'll try now w/o patch)

The same problem exists running R18 (similar to 18.12.2)

Note that, despite not having applied the patch, R18 works using "gradlew cleanAll loadAll ofbiz"

The error in log starts with. I'll have a look (since it's OK in trunk)

2021-11-03 16:26:24,132 |jsse-nio-8443-exec-4 |ControlServlet                |T| [[[ViewBlogRss(Domain:https://localhost)] Request Begun, 
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2021-11-03 16:26:24,134 |jsse-nio-8443-exec-4 |ServiceEventHandler           |E| =============== Found URL parameter [blogContentId] passed to secure 
(https) request-map with uri [ViewBlogRss] with an event that calls service [generateBl
ogRssFeed]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the 
request URL. Moreover it would be kind if you could create a Jira sub-task of https://
issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue 
please have a look before at https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Cont
ributors+Best+Practices Thank you in advance for your help.; In session [ hidden sessionId by default.]; Note that this can be changed using the 
service.http.parameters.require.encrypted property in the url.properties file
2021-11-03 16:26:24,199 |jsse-nio-8443-exec-4 |UtilProperties                |I| ResourceBundle WebappUiLabels (en_US) created in 0.064s with 27 
properties
2021-11-03 16:26:24,199 |jsse-nio-8443-exec-4 |RequestHandler                |E| Request ViewBlogRss caused an error with the following message: Error 
calling event: org.apache.ofbiz.webapp.event.EventHandlerException: Found URL paramete
r [blogContentId] passed to secure (https) request-map with uri [ViewBlogRss] with an event that calls service [generateBlogRssFeed]; this is not 
allowed for security reasons! The data should be encrypted by making it part of the request
  body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of 
https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not
  sure how to create a Jira issue please have a look before at https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices 
Thank you in advance for your help.
2021-11-03 16:26:24,199 |jsse-nio-8443-exec-4 |RequestHandler                |I| Rendering View [error].  Hidden sessionId by default.


Re: [VOTE] Apache OFBiz 18.12.02

Posted by Jacques Le Roux <ja...@les7arts.com>.
This said, I tried to use
https://localhost:8443/ecomseo/ViewBlogRss?entryLinkReq=ViewBlogArticle&mainLinkReq=MainBlog&blogContentId=BLOGROOTBIGAL

and got

------------------------------------------------------------------------------------------------------------------------------------------------------
ERROR MESSAGE
------------------------------------------------------------------------------------------------------------------------------------------------------

ERROR in error page, (infinite loop or error page not found with name [/error/error.jsp]

Original error detected, maybe it would be helps you : java.lang.StackOverflowError

------------------------------------------------------------------------------------------------------------------------------------------------------


Not sure it's related (I'll try now w/o patch). It works in trunk demo:

https://demo-trunk.ofbiz.apache.org/ecomseo/ViewBlogRss?entryLinkReq=ViewBlogArticle&mainLinkReq=MainBlog&blogContentId=BLOGROOTBIGAL

Anyway it should not prevent us to release 18.12.2. Because I guess this issue is not a blocker, even if RSS is still used nowadays: 
https://www.google.fr/search?q=who+use+RSS+nowaydays&ie=UTF-8

HTH


Le 03/11/2021 à 15:45, Jacques Le Roux a écrit :
> -1, Wiebke has now a far better solution with https://github.com/apache/ofbiz-framework/pull/332 (tested locally)
>
> Jacques
>
> Le 03/11/2021 à 15:01, Michael Brohl a écrit :
>> -1
>>
>> I agree with Wiebke: it seems that the reason for the new release was not backported to the release branch.
>>
>> I also recommend to have a look at Wiebke's PR [1] as a permanent fix for the problem.
>>
>> Best regards,
>>
>> Michael Brohl
>>
>> ecomify GmbH - www.ecomify.de
>>
>>
>> [1] https://github.com/apache/ofbiz-framework/pull/332
>>
>>
>> Am 01.11.21 um 15:34 schrieb Jacopo Cappellato:
>>> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
>>> release from the release18.12 branch.
>>>
>>> The release files can be downloaded from here:
>>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>> and are:
>>> * apache-ofbiz-18.12.02.zip
>>> * KEYS: text file with keys
>>> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
>>> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>>>
>>> Please download and test the zip file and its signatures (for instructions
>>> on testing the signatures see http://www.apache.org/info/verification.html).
>>>
>>> Vote:
>>> [ +1] release as Apache OFBiz 18.12.02
>>> [ -1] do not release
>>>
>>> This vote will be open for 5 days.
>>>
>>> For more details about this process please refer to
>>> http://www.apache.org/foundation/voting.html
>>>
>>> Best Regards,
>>>
>>> Jacopo
>>>

Re: [VOTE] Apache OFBiz 18.12.02

Posted by Jacques Le Roux <ja...@les7arts.com>.
-1, Wiebke has now a far better solution with https://github.com/apache/ofbiz-framework/pull/332 (tested locally)

Jacques

Le 03/11/2021 à 15:01, Michael Brohl a écrit :
> -1
>
> I agree with Wiebke: it seems that the reason for the new release was not backported to the release branch.
>
> I also recommend to have a look at Wiebke's PR [1] as a permanent fix for the problem.
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> [1] https://github.com/apache/ofbiz-framework/pull/332
>
>
> Am 01.11.21 um 15:34 schrieb Jacopo Cappellato:
>> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
>> release from the release18.12 branch.
>>
>> The release files can be downloaded from here:
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>> and are:
>> * apache-ofbiz-18.12.02.zip
>> * KEYS: text file with keys
>> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
>> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>>
>> Please download and test the zip file and its signatures (for instructions
>> on testing the signatures see http://www.apache.org/info/verification.html).
>>
>> Vote:
>> [ +1] release as Apache OFBiz 18.12.02
>> [ -1] do not release
>>
>> This vote will be open for 5 days.
>>
>> For more details about this process please refer to
>> http://www.apache.org/foundation/voting.html
>>
>> Best Regards,
>>
>> Jacopo
>>

Re: [VOTE] Apache OFBiz 18.12.02

Posted by Michael Brohl <mi...@ecomify.de>.
-1

I agree with Wiebke: it seems that the reason for the new release was 
not backported to the release branch.

I also recommend to have a look at Wiebke's PR [1] as a permanent fix 
for the problem.

Best regards,

Michael Brohl

ecomify GmbH - www.ecomify.de


[1] https://github.com/apache/ofbiz-framework/pull/332


Am 01.11.21 um 15:34 schrieb Jacopo Cappellato:
> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
> release from the release18.12 branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> and are:
> * apache-ofbiz-18.12.02.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 18.12.02
> [ -1] do not release
>
> This vote will be open for 5 days.
>
> For more details about this process please refer to
> http://www.apache.org/foundation/voting.html
>
> Best Regards,
>
> Jacopo
>