[GitHub] [cloudstack] rhtyd commented on a change in pull request #4239: Disabling managing firewall - cloudstack-setup-management

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#discussion_r468513457



##########
File path: python/lib/cloudutils/syscfg.py
##########
@@ -201,15 +201,15 @@ def check(self):
         if not hostname.isSuccess():
             raise CloudInternalException("Checking hostname ... [Failed]\nPlease edit /etc/hosts, add a Fully Qualified Domain Name as your hostname\n")
         return True
-        
+
 class sysConfigServerRedhat(sysConfigServer):
     def __init__(self, glbEnv):
         super(sysConfigServerRedhat, self).__init__(glbEnv)
         self.svo = serviceOpsRedhat()
-        self.services = [firewallConfigServer(self)]

Review comment:
       @davidjumani I think we should revert the previous behaviour and simply print the statement. Otherwise, env will not deploy. Previously the cloudstack-setup-management would open firewall, now that you've changed it - either (a) document this and fix trillian to open the ports both CentOS/Ubuntu envs, or (b) just print the line for information sake.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org