You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zjureel <gi...@git.apache.org> on 2017/08/04 08:58:23 UTC

[GitHub] flink pull request #4476: [FLINK-7307] Add proper command line parsing tool ...

GitHub user zjureel opened a pull request:

    https://github.com/apache/flink/pull/4476

    [FLINK-7307] Add proper command line parsing tool to ClusterEntrypoint

    ## What is the purpose of the change
    
    Add a proper command line parsing tool `CommandLineParser` to the entry point of the `ClusterEntrypoint#parseArguments`
    
    
    ## Brief change log
    
      - *Add command line parsing tool `CommandLineParser`*
      - *Use `CommandLineParser` instead of `ParameterTool` in `ClusterEntrypoint#parseArguments`*
    
    
    ## Verifying this change
    
    *(Please pick either of the following options)*
    This change added tests and can be verified as follows:
    
    *(example:)*
      - *Added test case `CommandLineParserTest`*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjureel/flink FLINK-7307

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4476
    
----
commit 9074a186b7961e7218a053ed211876317514a6ee
Author: zjureel <zj...@gmail.com>
Date:   2017-08-04T08:49:35Z

    [FLINK-7307][improvement] Add proper command line parsing tool to ClusterEntrypoint

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4476: [FLINK-7307] Add proper command line parsing tool to Clus...

Posted by zjureel <gi...@git.apache.org>.
Github user zjureel commented on the issue:

    https://github.com/apache/flink/pull/4476
  
    @tillrohrmann @aljoscha I have fixed [https://issues.apache.org/jira/browse/FLINK-7307](https://issues.apache.org/jira/browse/FLINK-7307) in this PR, could you please have a look when you're free, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---