[jira] Closed: (DIRMINA-421) ProtocolEncoder.dispose() is called for every encode() call for UDP

["Trustin Lee (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DIRMINA-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee closed DIRMINA-421.
-------------------------------

    Resolution: Fixed

Done.

> ProtocolEncoder.dispose() is called for every encode() call for UDP
> -------------------------------------------------------------------
>
>                 Key: DIRMINA-421
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-421
>             Project: MINA
>          Issue Type: Bug
>          Components: Filter
>    Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.0.4, 1.1.1, 1.0.5, 1.1.2
>            Reporter: Trustin Lee
>            Assignee: Trustin Lee
>            Priority: Minor
>             Fix For: 1.0.6, 1.1.3
>
>
> In ProtocolCodecFilter.filterWrite(), we call ProtocolDecoder.dispose() for every encode() call for connectionless transports:
>         try {
>             encoder.encode(session, message, encoderOut);
>             ......
>         } catch (Throwable t) {
>             ......
>         } finally {
>             // Dispose the encoder if this session is connectionless.
>             if (session.getService().getMetadata().isConnectionless()) {
>                 disposeEncoder(session);
>             }
>         }
> Because we introduced IoSessionRecycler since 1.0, we don't need to call disposeEncoder for each write at all.  The finally block needs to be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.