You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/30 21:32:55 UTC
[GitHub] [ozone] jwminton opened a new pull request #2480: HDDS-5021 dev-support Dockerfile is badly outdated
jwminton opened a new pull request #2480:
URL: https://github.com/apache/ozone/pull/2480
## What changes were proposed in this pull request?
* To satisfy docker-compose requirements, the following apk packages were added:
python3-dev libffi-dev openssl-dev gcc libc-dev rust cargo make
All (yes, even rust) required according to docker compose doc: https://docs.docker.com/compose/install/#install-using-pip
* bumped the glibc package version
* removed protobuf installation
* replaced findbugs install with spotbugs per jira request
* bumped the ant version
* Changed the 'git clone...' operation to reference ozone.git while mirroring what was done before (previously used 'trunk' ozone uses 'master')
* pom.xml and the plugin version -- The plugin that installs a local version of node for the recon build needed its version to be bumped because of changes to the latest version of alpine/node/glibc/compatibility/etc. The old version causes libstdc++ library to not be found by node during the recon build, despite being installed. Latest plugin with the latest alpine works fine. Note that this docker image won't work until the ozone master version of pom.xml has the updated version number. For testing I was using a sed line to change it in place:
cd /tmp/ozone && \
sed -i '/<frontend-maven-plugin.version>/ s/1.10/1.12/' pom.xml && \
mvn package dependency:go-offline -DskipTests -pl :ozone-dist -am && \
I assume it will be ok once both of these changes go in at the same time.
* For the final mvn call, there was a '-P hdds' option that is no longer a valid profile and causes a warning. I removed it to prevent the warning, but I'm not sure if it should have been replaced with something else.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5021
## How was this patch tested?
Manual tests and manual docker image creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2480: HDDS-5021 dev-support Dockerfile is badly outdated
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2480:
URL: https://github.com/apache/ozone/pull/2480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2480: HDDS-5021 dev-support Dockerfile is badly outdated
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2480:
URL: https://github.com/apache/ozone/pull/2480#discussion_r680354810
##########
File path: hadoop-ozone/dev-support/docker/Dockerfile
##########
@@ -61,9 +49,9 @@ RUN addgroup -g 1000 default && \
#can be installed
USER jenkins1000
RUN cd /tmp && \
- git clone --depth=1 https://gitbox.apache.org/repos/asf/hadoop.git -b trunk && \
- cd /tmp/hadoop && \
- mvn package dependency:go-offline -DskipTests -P hdds -pl :ozone-dist -am && \
+ git clone --depth=1 https://gitbox.apache.org/repos/asf/ozone.git -b master && \
+ cd /tmp/ozone && \
+ mvn package dependency:go-offline -DskipTests -pl :ozone-dist -am && \
rm -rf /tmp/.m2/repository/org/apache/hadoop/*hdds* && \
rm -rf /tmp/.m2/repository/org/apache/hadoop/*ozone* && \
Review comment:
Ozone groupId and artifactId were changed recently (fa4ddbccf):
```suggestion
rm -rf /tmp/.m2/repository/org/apache/ozone/hdds* && \
rm -rf /tmp/.m2/repository/org/apache/ozone/ozone* && \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org