You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Scott Creeley <sc...@redhat.com> on 2014/10/15 23:39:32 UTC

Review Request 26778: Moving fs.defaultFS property from hadoop-env.xml and into core-site.xml for 2.1 and 2.0.6.GlusterFS stacks

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26778/
-----------------------------------------------------------

Review request for Ambari, Erin Boyd and subin m.


Repository: ambari


Description
-------

Moving fs.defaultFS property from hadoop-env.xml and into core-site.xml for  2.1 and 2.0.6.GlusterFS stacks


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/GLUSTERFS/configuration/core-site.xml 553b48d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/GLUSTERFS/configuration/hadoop-env.xml 6c6d4c1 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/configuration/core-site.xml 70e6479 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/configuration/hadoop-env.xml 6c6d4c1 

Diff: https://reviews.apache.org/r/26778/diff/


Testing
-------

The changes only include GlusterFS specific changes in the configuration .xml files

mvn clean test

Results :

[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 42 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [3.082s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.227s]
[INFO] Ambari Web ........................................ SUCCESS [23.419s]
[INFO] Ambari Views ...................................... SUCCESS [1.576s]
[INFO] Ambari Admin View ................................. SUCCESS [7.346s]
[INFO] Ambari Server ..................................... SUCCESS [15:27.436s]
[INFO] Ambari Agent ...................................... SUCCESS [12.278s]
[INFO] Ambari Client ..................................... SUCCESS [0.030s]
[INFO] Ambari Python Client .............................. SUCCESS [0.255s]
[INFO] Ambari Groovy Client .............................. SUCCESS [7.747s]
[INFO] Ambari Shell ...................................... SUCCESS [0.030s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.029s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [5.408s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:29.305s
[INFO] Finished at: Wed Oct 15 16:37:04 GMT-05:00 2014
[INFO] Final Memory: 64M/548M
[INFO] --------------------------------------------------------------


File Attachments
----------------

Trunk patch
  https://reviews.apache.org/media/uploaded/files/2014/10/15/54629574-f593-4477-abad-3a82f738e451__AMBARI-7798-Trunk.patch
Branch Patch
  https://reviews.apache.org/media/uploaded/files/2014/10/15/ebc12fb1-efef-438f-867f-fe965e2db218__AMBARI-7798-Branch.patch


Thanks,

Scott Creeley


Re: Review Request 26778: Moving fs.defaultFS property from hadoop-env.xml and into core-site.xml for 2.1 and 2.0.6.GlusterFS stacks

Posted by Erin Boyd <eb...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26778/#review56821
-----------------------------------------------------------

Ship it!


Ship It!

- Erin Boyd


On Oct. 15, 2014, 9:39 p.m., Scott Creeley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26778/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 9:39 p.m.)
> 
> 
> Review request for Ambari, Erin Boyd and subin m.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Moving fs.defaultFS property from hadoop-env.xml and into core-site.xml for  2.1 and 2.0.6.GlusterFS stacks
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/GLUSTERFS/configuration/core-site.xml 553b48d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/GLUSTERFS/configuration/hadoop-env.xml 6c6d4c1 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/configuration/core-site.xml 70e6479 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/configuration/hadoop-env.xml 6c6d4c1 
> 
> Diff: https://reviews.apache.org/r/26778/diff/
> 
> 
> Testing
> -------
> 
> The changes only include GlusterFS specific changes in the configuration .xml files
> 
> mvn clean test
> 
> Results :
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 42 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.082s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.227s]
> [INFO] Ambari Web ........................................ SUCCESS [23.419s]
> [INFO] Ambari Views ...................................... SUCCESS [1.576s]
> [INFO] Ambari Admin View ................................. SUCCESS [7.346s]
> [INFO] Ambari Server ..................................... SUCCESS [15:27.436s]
> [INFO] Ambari Agent ...................................... SUCCESS [12.278s]
> [INFO] Ambari Client ..................................... SUCCESS [0.030s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.255s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [7.747s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.030s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.029s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [5.408s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 16:29.305s
> [INFO] Finished at: Wed Oct 15 16:37:04 GMT-05:00 2014
> [INFO] Final Memory: 64M/548M
> [INFO] --------------------------------------------------------------
> 
> 
> File Attachments
> ----------------
> 
> Trunk patch
>   https://reviews.apache.org/media/uploaded/files/2014/10/15/54629574-f593-4477-abad-3a82f738e451__AMBARI-7798-Trunk.patch
> Branch Patch
>   https://reviews.apache.org/media/uploaded/files/2014/10/15/ebc12fb1-efef-438f-867f-fe965e2db218__AMBARI-7798-Branch.patch
> 
> 
> Thanks,
> 
> Scott Creeley
> 
>


Re: Review Request 26778: Moving fs.defaultFS property from hadoop-env.xml and into core-site.xml for 2.1 and 2.0.6.GlusterFS stacks

Posted by Erin Boyd <eb...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26778/#review56820
-----------------------------------------------------------

Ship it!


Ship It!

- Erin Boyd


On Oct. 15, 2014, 9:39 p.m., Scott Creeley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26778/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 9:39 p.m.)
> 
> 
> Review request for Ambari, Erin Boyd and subin m.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Moving fs.defaultFS property from hadoop-env.xml and into core-site.xml for  2.1 and 2.0.6.GlusterFS stacks
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/GLUSTERFS/configuration/core-site.xml 553b48d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/GLUSTERFS/configuration/hadoop-env.xml 6c6d4c1 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/configuration/core-site.xml 70e6479 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/configuration/hadoop-env.xml 6c6d4c1 
> 
> Diff: https://reviews.apache.org/r/26778/diff/
> 
> 
> Testing
> -------
> 
> The changes only include GlusterFS specific changes in the configuration .xml files
> 
> mvn clean test
> 
> Results :
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 42 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.082s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.227s]
> [INFO] Ambari Web ........................................ SUCCESS [23.419s]
> [INFO] Ambari Views ...................................... SUCCESS [1.576s]
> [INFO] Ambari Admin View ................................. SUCCESS [7.346s]
> [INFO] Ambari Server ..................................... SUCCESS [15:27.436s]
> [INFO] Ambari Agent ...................................... SUCCESS [12.278s]
> [INFO] Ambari Client ..................................... SUCCESS [0.030s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.255s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [7.747s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.030s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.029s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [5.408s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 16:29.305s
> [INFO] Finished at: Wed Oct 15 16:37:04 GMT-05:00 2014
> [INFO] Final Memory: 64M/548M
> [INFO] --------------------------------------------------------------
> 
> 
> File Attachments
> ----------------
> 
> Trunk patch
>   https://reviews.apache.org/media/uploaded/files/2014/10/15/54629574-f593-4477-abad-3a82f738e451__AMBARI-7798-Trunk.patch
> Branch Patch
>   https://reviews.apache.org/media/uploaded/files/2014/10/15/ebc12fb1-efef-438f-867f-fe965e2db218__AMBARI-7798-Branch.patch
> 
> 
> Thanks,
> 
> Scott Creeley
> 
>