You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/02 09:30:31 UTC
[GitHub] [arrow-datafusion] NaincyKumariKnoldus opened a new pull request #1904: Fixed : Rust version requirement is not mentioned in the developer's guide.
NaincyKumariKnoldus opened a new pull request #1904:
URL: https://github.com/apache/arrow-datafusion/pull/1904
Hey @HaoYang670 I have added rustup update stable in in the Bootstrap environment part, because we always use the latest stable version of Rust to test this project.
Please review this. If any changes needed inform me i will do that.
Thanks!
#1894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on pull request #1904: Fixed : Rust version requirement is not mentioned in the developer's guide.
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on pull request #1904:
URL: https://github.com/apache/arrow-datafusion/pull/1904#issuecomment-1056711857
Maybe you could add some context. @NaincyKumariKnoldus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1904: Fixed : Rust version requirement is not mentioned in the developer's guide.
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1904:
URL: https://github.com/apache/arrow-datafusion/pull/1904#issuecomment-1058091532
Thank you @NaincyKumariKnoldus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1904: Fixed : Rust version requirement is not mentioned in the developer's guide.
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1904:
URL: https://github.com/apache/arrow-datafusion/pull/1904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] NaincyKumariKnoldus commented on pull request #1904: Fixed : Rust version requirement is not mentioned in the developer's guide.
Posted by GitBox <gi...@apache.org>.
NaincyKumariKnoldus commented on pull request #1904:
URL: https://github.com/apache/arrow-datafusion/pull/1904#issuecomment-1056720891
> Maybe you could add some context. @NaincyKumariKnoldus
context such as? can you suggest I will add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1904: Fixed : Rust version requirement is not mentioned in the developer's guide.
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1904:
URL: https://github.com/apache/arrow-datafusion/pull/1904#discussion_r817872753
##########
File path: DEVELOPERS.md
##########
@@ -35,6 +35,7 @@ DataFusion is written in Rust and it uses a standard rust toolkit:
Testing setup:
Review comment:
I wonder if we should add a short note saying "DataFusion uses the latest stable release of rust" as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on pull request #1904: Fixed : Rust version requirement is not mentioned in the developer's guide.
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on pull request #1904:
URL: https://github.com/apache/arrow-datafusion/pull/1904#issuecomment-1056703225
@alamb please trigger the workflows, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on pull request #1904: Fixed : Rust version requirement is not mentioned in the developer's guide.
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on pull request #1904:
URL: https://github.com/apache/arrow-datafusion/pull/1904#issuecomment-1056688105
nit: Please add `Closes #1894 ` into your comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] NaincyKumariKnoldus commented on a change in pull request #1904: Fixed : Rust version requirement is not mentioned in the developer's guide.
Posted by GitBox <gi...@apache.org>.
NaincyKumariKnoldus commented on a change in pull request #1904:
URL: https://github.com/apache/arrow-datafusion/pull/1904#discussion_r818472203
##########
File path: DEVELOPERS.md
##########
@@ -35,6 +35,7 @@ DataFusion is written in Rust and it uses a standard rust toolkit:
Testing setup:
Review comment:
yes @alamb and @HaoYang670 I have added now you can check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org