You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by es...@apache.org on 2019/01/17 19:35:48 UTC

[geode] branch feature/GEODE-6212 updated: fix a review comment.

This is an automated email from the ASF dual-hosted git repository.

eshu11 pushed a commit to branch feature/GEODE-6212
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/feature/GEODE-6212 by this push:
     new 86ba0ff  fix a review comment.
86ba0ff is described below

commit 86ba0ffcb24cd1fd16deccf328fb1378f6fa6a7b
Author: Eric Shu <es...@Eric-MacBook.local>
AuthorDate: Thu Jan 17 11:35:20 2019 -0800

    fix a review comment.
---
 .../internal/cache/ValueComparisonHelperTest.java  | 36 +++++++++++-----------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/ValueComparisonHelperTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/ValueComparisonHelperTest.java
index 8dadfdd..830ff7f 100644
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/ValueComparisonHelperTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/ValueComparisonHelperTest.java
@@ -30,24 +30,24 @@ import org.apache.geode.internal.offheap.StoredObject;
 import org.apache.geode.pdx.PdxInstance;
 
 public class ValueComparisonHelperTest {
-  private final String STRING = "ABCD";
-  private final byte[] BYTE_ARRAY = {65, 66, 67, 68};
-  private final String STRING2 = "EFGH";
-  private final int[] INT_ARRAY = {65, 66, 67, 68};
-  private final int[] INT_ARRAY2 = new int[] {65, 66, 67, 68};
-  private final int[] INT_ARRAY3 = new int[] {65, 66, 67, 69};
-  private final boolean[] BOOLEAN_ARRAY = {true, false, false, true};
-  private final boolean[] BOOLEAN_ARRAY2 = new boolean[] {true, false, false, true};
-  private final boolean[] BOOLEAN_ARRAY3 = new boolean[] {true, false, true, true};
-  private final short[] SHORT_ARRAY = {65, 66, 67, 68};
-  private final short[] SHORT_ARRAY2 = new short[] {65, 66, 67, 68};
-  private final short[] SHORT_ARRAY3 = new short[] {65, 66, 67, 69};
-  private final float[] FLOAT_ARRAY = {65.1f, 66.0f, 67.3f, 68.9f};
-  private final float[] FLOAT_ARRAY2 = new float[] {65.1f, 66.0f, 67.3f, 68.9f};
-  private final float[] FLOAT_ARRAY3 = {65.1f, 66.0f, 67.3f, 69.9f};
-  private final String[] STRING_ARRAY = {"ABCD", "EFGH"};
-  private final String[] STRING_ARRAY2 = {STRING, STRING2};
-  private final String[] STRING_ARRAY3 = {STRING, STRING2, ""};
+  private static final String STRING = "ABCD";
+  private static final byte[] BYTE_ARRAY = {65, 66, 67, 68};
+  private static final String STRING2 = "EFGH";
+  private static final int[] INT_ARRAY = {65, 66, 67, 68};
+  private static final int[] INT_ARRAY2 = new int[] {65, 66, 67, 68};
+  private static final int[] INT_ARRAY3 = new int[] {65, 66, 67, 69};
+  private static final boolean[] BOOLEAN_ARRAY = {true, false, false, true};
+  private static final boolean[] BOOLEAN_ARRAY2 = new boolean[] {true, false, false, true};
+  private static final boolean[] BOOLEAN_ARRAY3 = new boolean[] {true, false, true, true};
+  private static final short[] SHORT_ARRAY = {65, 66, 67, 68};
+  private static final short[] SHORT_ARRAY2 = new short[] {65, 66, 67, 68};
+  private static final short[] SHORT_ARRAY3 = new short[] {65, 66, 67, 69};
+  private static final float[] FLOAT_ARRAY = {65.1f, 66.0f, 67.3f, 68.9f};
+  private static final float[] FLOAT_ARRAY2 = new float[] {65.1f, 66.0f, 67.3f, 68.9f};
+  private static final float[] FLOAT_ARRAY3 = {65.1f, 66.0f, 67.3f, 69.9f};
+  private static final String[] STRING_ARRAY = {"ABCD", "EFGH"};
+  private static final String[] STRING_ARRAY2 = {STRING, STRING2};
+  private static final String[] STRING_ARRAY3 = {STRING, STRING2, ""};
 
   @Test
   public void basicEqualsCanCompareTwoNullObjects() {