You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <ja...@zenplex.com> on 2003/02/02 06:47:01 UTC
Re: cvs commit: jakarta-turbine-maven/src/test/touchstone-build
maven.xml
On Sat, 2003-02-01 at 23:58, Ben Walding wrote:
> I've commented out the failing test. Maven-242 has been raised to
> reenable it when appropriate
>
> While I appreciate what you did, a non functional HEAD makes life
> extremely difficult for those of us who do clean builds to check that
> our changes haven't hosed something else. It also contributes to a raft
> of discussion on the mailing lists and IRC as people cumulatively waste
> hours trying to solve it for themselves.
>
> I think this falls into the realm of test categories - fast, slow,
> broken etc. If I could disable the known broken tests that would suit
> my purposes. And conversely, any known broken test that worked should
> count as a failure! (so that it can be moved to working tests)
It's certainly good to put failing tests into the touchstone build, just
leave it out of the 'touchstone-tests' goal until the problem is solved.
> Cheers,
>
> Ben
>
> plynch@apache.org wrote:
>
> >plynch 2003/02/01 03:22:24
> >
> > Modified: src/test/touchstone-build maven.xml
> > Log:
> > o adding failing test. It currently is set the fail the build, I hope that is what is wanted.
> >
> > If a property is defined with dots, say to 'true', when evaluated with the following expression:
> >
> > ${dot.property == null}
> >
> > The expression is evaluated as true even though the real value is not null.
> >
> > Revision Changes Path
> > 1.24 +44 -35 jakarta-turbine-maven/src/test/touchstone-build/maven.xml
> >
> > Index: maven.xml
> > ===================================================================
> > RCS file: /home/cvs/jakarta-turbine-maven/src/test/touchstone-build/maven.xml,v
> > retrieving revision 1.23
> > retrieving revision 1.24
> > diff -u -r1.23 -r1.24
> > --- maven.xml 29 Jan 2003 18:35:15 -0000 1.23
> > +++ maven.xml 1 Feb 2003 11:22:24 -0000 1.24
> > @@ -20,13 +20,13 @@
> > |
> > | How to add a test to the touchstone:
> > |
> > - | The way things are currently set up is that for each test you want to
> > + | The way things are currently set up is that for each test you want to
> > | perform you make a separate goal for it.
> > |
> > | After you have made your goal which executes what you feel is incorrect
> > | you add an <attainGoal name="your-test"/> inside the 'touchstone-tests'
> > - | goal and then you can put a little check beneath the <attainGoal/> that checks
> > - | values or whatever else you want to check. The pattern so far is to use
> > + | goal and then you can put a little check beneath the <attainGoal/> that checks
> > + | values or whatever else you want to check. The pattern so far is to use
> > | the <fail/> tag when something goes wrong which will halt the bootstrap.
> > |
> > | If you wish to check plugin functionality of any sort there is a
> > @@ -42,7 +42,7 @@
> > -->
> >
> > <goal name="touchstone-tests">
> > -
> > +
> > <attainGoal name="touchstone-goal-A"/>
> > <j:set var="checkValue" value="${pom.getPluginContext('maven-touchstone-plugin').getVariable('touchstone_goal_A_from_plugin')}"/>
> > <j:if test="${checkValue == 'true'}">
> > @@ -72,7 +72,7 @@
> > <j:set var="resultantPath" value="/path1:/path2"/>
> > </j:otherwise>
> > </j:choose>
> > -
> > +
> > <j:if test="${pom.antProject.getReferences().get('testPath') != resultantPath}">
> > <property name="testPathProp" refid="testPath" />
> > <property name="testPath1Prop" refid="testPath1" />
> > @@ -85,18 +85,18 @@
> > testPath2 = ${testPath2Prop}
> > </fail>
> > </j:if>
> > -
> > +
> >
> > <attainGoal name="test-plugin-property-override"/>
> > <j:set var="mavenTouchstoneA" value="${maven.touchstone.A}"/>
> > <j:if test="${mavenTouchstoneA != 'override.maven.touchstone.A'}">
> > <fail message="">
> > -
> > +
> > Plugin properties are not being correctly overriden.
> > -
> > +
> > </fail>
> > </j:if>
> > -
> > +
> > <!--
> > |
> > | artifactId check.
> > @@ -104,10 +104,10 @@
> > -->
> > <j:if test="${pom.artifactDirectory != 'touchstone'}">
> > <fail message="">
> > -
> > +
> > The artifactDirectory should be in legacy form which
> > contains no ":" character.
> > -
> > +
> > </fail>
> > </j:if>
> >
> > @@ -118,26 +118,26 @@
> > -->
> > <j:if test="${pom.getProperty('propertyA') != 'pomPropertyA'}">
> > <fail message="">
> > -
> > +
> > Problem resolving project level embedded properties.
> > -
> > +
> > </fail>
> > </j:if>
> > -
> > +
> > <j:if test="${pom.getDependency('a').getProperty('propertyA') != 'depPropertyA'}">
> > <fail message="">
> > -
> > +
> > Problem resolving dependency level embedded properties.
> > -
> > +
> > </fail>
> > </j:if>
> > -
> > +
> > <!--
> > |
> > | Inter-plugin preGoal tests.
> > |
> > -->
> > -
> > +
> > <!--
> > |
> > | Touchstone partner has a pregoal which sets a variable.
> > @@ -148,9 +148,9 @@
> > <echo>checkValue = ${checkValue}</echo>
> > <j:if test="${checkValue != 'true'}">
> > <fail message="">
> > -
> > +
> > Inter-plugin preGoals are not being dealt with correctly.
> > -
> > +
> > </fail>
> > </j:if>
> >
> > @@ -164,15 +164,24 @@
> > <echo>checkValue = ${checkValue}</echo>
> > <j:if test="${checkValue != 'true'}">
> > <fail message="">
> > -
> > +
> > Inter-plugin preGoals are not being dealt with correctly.
> > -
> > +
> > </fail>
> > </j:if>
> > -
> > +
> > +
> > + <!-- property wrongly treated as == null -->
> > + <property name="dot.property" value="true" />
> > + <j:if test="${dot.property == null}" >
> > + <fail>
> > +A defined property with dots in the name is wrongly treated as null
> > +even though the value is ${dot.property} </fail>
> > + </j:if>
> > +
> > </goal>
> >
> > - <!--
> > + <!--
> > |
> > | T E S T S
> > |
> > @@ -187,7 +196,7 @@
> > <j:set var="dist" value="${maven.build.dir}/dist"/>
> > <deploy:copy-deps todir="${dist}/lib"/>
> > </goal>
> > -
> > +
> > <!--
> > |
> > | <sea:create/> test.
> > @@ -224,23 +233,23 @@
> > |
> > -->
> > <goal name="test-addPath">
> > -
> > +
> > <path id="testPath1">
> > <pathelement location="/path1"/>
> > </path>
> > -
> > +
> > <path id="testPath2">
> > <pathelement location="/path2"/>
> > </path>
> > -
> > +
> > <path id="testPath">
> > </path>
> > -
> > +
> > <maven:addPath id="testPath" refid="testPath1"/>
> > <maven:addPath id="testPath" refid="testPath2"/>
> >
> > </goal>
> > -
> > +
> > <!--
> > |
> > | Local goal overriding test.
> > @@ -249,7 +258,7 @@
> > <goal name="touchstone-goal-A">
> > <echo>Overriding touchstone-goal-A</echo>
> > </goal>
> > -
> > +
> > <!--
> > |
> > | Plugin property override test.
> > @@ -305,14 +314,14 @@
> > -->
> >
> > <preGoal name="java:compile">
> > -
> > +
> > <!-- Display maven.dependency.classpath in a nice format. -->
> > -
> > - <property
> > +
> > + <property
> > name="mavenDependencyClasspath"
> > refid="maven.dependency.classpath"
> > />
> > -
> > +
> > <j:choose>
> > <j:when test="${systemScope['os.name'].startsWith('Windows')}">
> > <u:tokenize var="classpath" delim=";">${mavenDependencyClasspath}</u:tokenize>
> >
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: turbine-maven-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: turbine-maven-dev-help@jakarta.apache.org
> >
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-maven-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-maven-dev-help@jakarta.apache.org
--
jvz.
Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org
In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
-- Jacques Ellul, The Technological Society
Re: cvs commit: jakarta-turbine-maven/src/test/touchstone-buildmaven.xml
Posted by Peter Lynch <pe...@mindspring.com>.
----- Original Message -----
From: "Jason van Zyl" <ja...@zenplex.com>
To: "Turbine Maven Developers List" <tu...@jakarta.apache.org>
Sent: Saturday, February 01, 2003 9:47 PM
Subject: Re: cvs commit:
jakarta-turbine-maven/src/test/touchstone-buildmaven.xml
> On Sat, 2003-02-01 at 23:58, Ben Walding wrote:
> > I've commented out the failing test. Maven-242 has been raised to
> > reenable it when appropriate
> >
> > While I appreciate what you did, a non functional HEAD makes life
> > extremely difficult for those of us who do clean builds to check that
> > our changes haven't hosed something else. It also contributes to a raft
> > of discussion on the mailing lists and IRC as people cumulatively waste
> > hours trying to solve it for themselves.
> >
> > I think this falls into the realm of test categories - fast, slow,
> > broken etc. If I could disable the known broken tests that would suit
> > my purposes. And conversely, any known broken test that worked should
> > count as a failure! (so that it can be moved to working tests)
>
> It's certainly good to put failing tests into the touchstone build, just
> leave it out of the 'touchstone-tests' goal until the problem is solved.
Ahh ok, will do.
-Peter
>
> > Cheers,
> >
> > Ben
<snip />