You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Georg Henzler (JIRA)" <ji...@apache.org> on 2018/11/05 21:32:00 UTC
[jira] [Comment Edited] (FELIX-5952) Felix Health Checks
[ https://issues.apache.org/jira/browse/FELIX-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675773#comment-16675773 ]
Georg Henzler edited comment on FELIX-5952 at 11/5/18 9:31 PM:
---------------------------------------------------------------
Attached [^FELIX-5952-new-module-healthcheck-initial-version-v4.zip] with the following improvements:
* Also took over the web console (dependency to org.apache.sling.api that was only used for escaping strings for html was replaced by commons lang StringEscapeUtils.escapeHtml4)
* Following the feedback from [~chris@die-schneider.net] / [~andrei.dulvac]: Removed result status values "DEBUG" and "INFO" as they should have been used only by FormattingResultLog (for the very unlikely case somebody used those status values directly, this will go into the migration guide). FormattingResultLog still supports the debug and info methods (as those make totally sense), however those status are kept as status "OK" while debug log entries are marked as debug with a boolean flag. With that approach the Result.Status enum is now clean.
was (Author: henzlerg):
Attached [^FELIX-5952-new-module-healthcheck-initial-version-v4.zip] with the following improvements:
* Also took over the web console (dependency to org.apache.sling.api that was only used for escaping strings for html was replaced by commons lang StringEscapeUtils.escapeHtml4)
* Following the feedback from [~chris@die-schneider.net] / [~andrei.dulvac]: Removed result status values "DEBUG" and "INFO" as they should only be used by FormattingResultLog (for the very unlikely case somebody directly used those status values directly, this will go into the migration guide). FormattingResultLog still supports the debug and info methods (as those make totally sense), however those status are kept as status "OK" while debug log entries are marked as debug with a boolean flag. With that approach the Result.Status enum is now clean.
> Felix Health Checks
> -------------------
>
> Key: FELIX-5952
> URL: https://issues.apache.org/jira/browse/FELIX-5952
> Project: Felix
> Issue Type: New Feature
> Reporter: Georg Henzler
> Assignee: Karl Pauls
> Priority: Major
> Attachments: FELIX-5952-new-module-healthcheck-initial-version-v2.zip, FELIX-5952-new-module-healthcheck-initial-version-v4.zip, FELIX-5952-new-module-healthcheck-initial-version.zip
>
>
> Sling Health Checks [1] allow to check a system's health manually (humans) or technically (load balancers, Kubernetes, etc.). Since Sling HCs have minimal dependencies to Sling, they should be brought to Felix to make them available to a broader audience and to to be able to use the executor runtime for the systemready checks - see [2] for the discussion on the Sling mailing list.
> [1] https://sling.apache.org/documentation/bundles/sling-health-check-tool.html
> [2] http://apache-sling.73963.n3.nabble.com/hackathon-health-checks-td4086283.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)