You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/07 07:19:00 UTC

[GitHub] [spark] viirya commented on pull request #33912: [SPARK-36670][SPARK-36669][CORE][SQL] Add LZ4 hadoop wrapper and FileSourceCodecSuite

viirya commented on pull request #33912:
URL: https://github.com/apache/spark/pull/33912#issuecomment-914055005


   > Could we add a test for hadoop seq files using `sc.sequenceFile(...)`? There are still many legacy applications using hadoop seq files, and we want to ensure it works.
   > 
   > We might want to exclude the relocation of snappy in Hadoop as well.
   
   Let me add test for hadoop seq files in different PR.
   
   For snappy-java, that's good point. Looks like we also need to exclude it from relocation in Hadoop.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org