You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/01 11:01:49 UTC
[GitHub] [airflow] turbaszek commented on a change in pull request #14001: added missing return parameter in read function of FileTaskHandler
turbaszek commented on a change in pull request #14001:
URL: https://github.com/apache/airflow/pull/14001#discussion_r567736120
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -207,7 +207,7 @@ def read(self, task_instance, try_number=None, metadata=None):
logs = [
[('default_host', f'Error fetching the logs. Try number {try_number} is invalid.')],
]
- return logs
+ return logs, [{'end_of_log': True}]
Review comment:
This is interesting because such error should be spotted by `pylint` as inconsistent return statement. I think this is yet another time when I have a feeling that our pylint may not work perfectly well. CC @kaxil @ashb @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org