You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/27 13:53:00 UTC

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #248: [FLINK-28712] Default Changelog all when changelog producer is input

LadyForest commented on code in PR #248:
URL: https://github.com/apache/flink-table-store/pull/248#discussion_r931091615


##########
docs/content/docs/development/streaming-query.md:
##########
@@ -75,14 +75,14 @@ streaming mode. This mode has a lower cost compared to Kafka but has a higher la
 depending on the checkpoint interval of the writing job.
 
 By default, the downstream streaming consumption is disordered (ordered within the key)
-stream of upsert data. If you expect an ordered CDC data stream, you can configure it
-as follows (recommended):
+stream of upsert data. If you expect an ordered CDC data stream, and remove downstream

Review Comment:
   I feel it is a little hard to understand from a user's perspective. A more intuitive way is to add an example and some pic(s) to illustrate.
   
   For example, we can take `ChangelogWithKeyFileStoreTableTest#testStreamingChangelog` to explain the final result difference between enable/disable `ChangelogProducer.INPUT`
   
   And meanwhile, add some pic to illustrate the processing difference



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org