You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Focus-rth (via GitHub)" <gi...@apache.org> on 2023/03/20 03:48:50 UTC
[GitHub] [rocketmq] Focus-rth opened a new pull request, #6401: opt transation message check
Focus-rth opened a new pull request, #6401:
URL: https://github.com/apache/rocketmq/pull/6401
If you specify a custom first check time CheckImmunityTimeInSeconds,A…
**Make sure set the target branch to `develop`**
## What is the purpose of the change
<!--
If this PR fixes a GitHub issue, please add `fixes #<XXX>` or `closes #<XXX>`. Please refer to the documentation for more information:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
fix #<xxx> <!-- <xxx> replace with issue id -->
## Brief changelog
If you specify a custom first check time CheckImmunityTimeInSeconds,And the commit/rollback request whose validity period exceeds CheckImmunityTimeInSeconds and is not checked back will be processed and failed
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] fuyou001 merged pull request #6401: [ISSUE #6402]opt transaction message check
Posted by "fuyou001 (via GitHub)" <gi...@apache.org>.
fuyou001 merged PR #6401:
URL: https://github.com/apache/rocketmq/pull/6401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6401: [ISSUE #6402]opt transaction message check
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6401:
URL: https://github.com/apache/rocketmq/pull/6401#issuecomment-1475599068
## [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6401?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6401](https://codecov.io/gh/apache/rocketmq/pull/6401?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a82b61d) into [develop](https://codecov.io/gh/apache/rocketmq/commit/68362151a272cce4e318238138b5e5de5344220f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6836215) will **increase** coverage by `0.01%`.
> The diff coverage is `96.29%`.
> :exclamation: Current head a82b61d differs from pull request most recent head dd8ffcb. Consider uploading reports for the commit dd8ffcb to get more accurate results
```diff
@@ Coverage Diff @@
## develop #6401 +/- ##
=============================================
+ Coverage 43.11% 43.12% +0.01%
- Complexity 8911 8926 +15
=============================================
Files 1105 1105
Lines 77961 77988 +27
Branches 10144 10149 +5
=============================================
+ Hits 33611 33635 +24
- Misses 40136 40139 +3
Partials 4214 4214
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/rocketmq/remoting/protocol/ResponseCode.java](https://codecov.io/gh/apache/rocketmq/pull/6401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1Jlc3BvbnNlQ29kZS5qYXZh) | `0.00% <ø> (ø)` | |
| [...etmq/broker/processor/EndTransactionProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/6401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0VuZFRyYW5zYWN0aW9uUHJvY2Vzc29yLmphdmE=) | `54.18% <95.00%> (+8.27%)` | :arrow_up: |
| [...er/transaction/queue/TransactionalMessageUtil.java](https://codecov.io/gh/apache/rocketmq/pull/6401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdHJhbnNhY3Rpb24vcXVldWUvVHJhbnNhY3Rpb25hbE1lc3NhZ2VVdGlsLmphdmE=) | `91.17% <100.00%> (+2.28%)` | :arrow_up: |
... and [26 files with indirect coverage changes](https://codecov.io/gh/apache/rocketmq/pull/6401/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-code-scanning[bot] commented on pull request #6401: opt transaction message check
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on PR #6401:
URL: https://github.com/apache/rocketmq/pull/6401#issuecomment-1475580920
You have successfully added a new CodeQL configuration `.github/workflows/codeql_analysis.yml:CodeQL-Build`. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository [Security tab](/apache/rocketmq/security/code-scanning?query=pr%3A6401+tool%3ACodeQL+is%3Aopen) to see all alerts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org