[GitHub] [solr] janhoy commented on a diff in pull request #1151: SOLR-16155 DocumentBuilder should not include field values in error msgs

[GitBox <gi...@apache.org>]

janhoy commented on code in PR #1151:
URL: https://github.com/apache/solr/pull/1151#discussion_r1024939636


##########
solr/core/src/test/org/apache/solr/update/processor/TolerantUpdateProcessorTest.java:
##########
@@ -260,8 +259,7 @@ public void testMaxErrors0() {
                     "tolerant-chain-max-errors-10", smallBatch, requestParams, "1"));
     assertTrue(
         e.getMessage()
-            .contains(
-                "ERROR: [doc=1] Error adding field 'weight'='b' msg=For input string: \"b\""));

Review Comment:
   Yea, you're right, still leaks the value from the exception message. The "For input string" text is from `NumberFormatException`, probably in `Integer.parseInt()` when some class somewhere parses a weight field. Question is whether we could instead print something like
   > Error adding fidle 'weight'. Exception: NumberFormatException



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org