You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/05/29 22:24:59 UTC
Review Request: WDRF 7 - Update documentation related to allocator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11529/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
See summary.
Diffs
-----
docs/Allocation-module.textile 45d66d1
docs/Configuration.textile 1c441c2
Diff: https://reviews.apache.org/r/11529/diff/
Testing
-------
Thanks,
Thomas Marshall
Re: Review Request: WDRF 7 - Update documentation related to allocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11529/
-----------------------------------------------------------
(Updated June 13, 2013, 7:34 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Ben's review - took allocator related flags out of the config page for simplicity. Also added a description of how DRF weighting works to the allocator page.
Description
-------
See summary.
This addresses bug MESOS-504.
https://issues.apache.org/jira/browse/MESOS-504
Diffs (updated)
-----
docs/Allocation-module.textile 45d66d1
docs/Configuration.textile 1c441c2
Diff: https://reviews.apache.org/r/11529/diff/
Testing
-------
Thanks,
Thomas Marshall
Re: Review Request: WDRF 7 - Update documentation related to allocator
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11529/
-----------------------------------------------------------
(Updated June 12, 2013, 11:41 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Added bug.
Description
-------
See summary.
This addresses bug MESOS-504.
https://issues.apache.org/jira/browse/MESOS-504
Diffs
-----
docs/Allocation-module.textile 45d66d1
docs/Configuration.textile 1c441c2
Diff: https://reviews.apache.org/r/11529/diff/
Testing
-------
Thanks,
Thomas Marshall
Re: Review Request: WDRF 7 - Update documentation related to allocator
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11529/#review21822
-----------------------------------------------------------
Ship it!
Of course, based on how previous reviews might change, I'll assume you'll update any changes here.
docs/Configuration.textile
<https://reviews.apache.org/r/11529/#comment45036>
In the long run we should really have users just do '--help' to get all of this information. I love that you're trying to be diligent and update this, but IMHO it's tedious and error prone and ultimately really unnecessary (if someone is reading the flags documentation it's because they want to run the binary and if they want to run they binary they can probably run '--help').
- Benjamin Hindman
On June 5, 2013, 9:55 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11529/
> -----------------------------------------------------------
>
> (Updated June 5, 2013, 9:55 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/Allocation-module.textile 45d66d1
> docs/Configuration.textile 1c441c2
>
> Diff: https://reviews.apache.org/r/11529/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: WDRF 7 - Update documentation related to allocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11529/
-----------------------------------------------------------
(Updated June 5, 2013, 9:55 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated to reflect the addition of the weights command line option.
Description
-------
See summary.
Diffs (updated)
-----
docs/Allocation-module.textile 45d66d1
docs/Configuration.textile 1c441c2
Diff: https://reviews.apache.org/r/11529/diff/
Testing
-------
Thanks,
Thomas Marshall