You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/04/11 12:27:28 UTC

Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
-----------------------------------------------------------

Review request for mesos, Neil Conway and Till Toenshoff.


Bugs: MESOS-7193
    https://issues.apache.org/jira/browse/MESOS-7193


Repository: mesos


Description
-------

Using 'GTEST_IS_THREADSAFE' in asserts to fail tests that need
thread-safety early is problematic, because it may be undefined.
Instead, a new assertion is introduced that evaluates
'GTEST_IS_THREADSAFE' and succeeds or fails accordingly.


Diffs
-----

  3rdparty/libprocess/include/process/gtest.hpp 27077ac9047447fc4c52cc76ab26420e5bc79418 
  3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
  3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
  3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
  3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
  3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
  3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 


Diff: https://reviews.apache.org/r/58347/diff/1/


Testing
-------

libprocess-tests (using automake and CMake with macOS, Linux, Windows)


Thanks,

Jan Schlicht

Re: Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.

Posted by Joseph Wu <jo...@mesosphere.io>.

> On April 11, 2017, 11:45 a.m., Neil Conway wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp
> > Line 294 (original), 294 (patched)
> > <https://reviews.apache.org/r/58347/diff/1/?file=1687944#file1687944line294>
> >
> >     Seems like the reference to `GTEST_IS_THREADSAFE` should be updated, here and elsewhere.

One thing to note: Upgrading gtest to 1.8 will bring thread-safety support to Windows ( https://reviews.apache.org/r/58349/ ), so the macro will actually be defined.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review171598
-----------------------------------------------------------


On April 11, 2017, 5:27 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 5:27 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7193
>     https://issues.apache.org/jira/browse/MESOS-7193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using 'GTEST_IS_THREADSAFE' in asserts to fail tests that need
> thread-safety early is problematic, because it may be undefined.
> Instead, a new assertion is introduced that evaluates
> 'GTEST_IS_THREADSAFE' and succeeds or fails accordingly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 27077ac9047447fc4c52cc76ab26420e5bc79418 
>   3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
>   3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
>   3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
>   3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 
> 
> 
> Diff: https://reviews.apache.org/r/58347/diff/1/
> 
> 
> Testing
> -------
> 
> libprocess-tests (using automake and CMake with macOS, Linux, Windows)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

Posted by Jan Schlicht <ja...@mesosphere.io>.

> On April 11, 2017, 8:45 p.m., Neil Conway wrote:
> > I'm curious what the goal of these assertions is: to fail the test (at runtime) if the current version of GTest is not thread-safe, right? It seems weird to be doing that at runtime, since whether GTest is threadsafe or not seems to be a compile-time property.
> > 
> > Would it make more sense to just avoid compiling these tests if `GTEST_IS_THREADSAFE` is not defined?
> 
> Jan Schlicht wrote:
>     Yes, we could do something like
>     ```
>     #if GTEST_IS_THREADSAFE
>     #define TEST_THREADSAFE(test_case_name, test_name) \
>       TEST(test_case_name, test_name)
>     #else
>     #define TEST_THREADSAFE(test_case_name, test_name) \
>       TEST(test_case_name, DISABLED_##test_name)
>     #endif
>     ```
>     similar to the `TEST_TEMP_DISABLED_ON_WINDOWS` macros, or use a `THREADSAFE_` prefix in the test name and add a filter for these tests. I prefer the second solution, because it allows a test case to have mutiple prefixes and will implement that.

I've implemented test filters to not run these tests if `GTEST_IS_THREADSAFE` isn't defined.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review171598
-----------------------------------------------------------


On April 24, 2017, 1:22 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 1:22 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7193
>     https://issues.apache.org/jira/browse/MESOS-7193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of using asserts that would fail a test at runtime when
> thread-safety of the test environment isn't given, these tests are now
> filtered out before running the tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
>   3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
>   3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
>   3rdparty/libprocess/src/tests/main.cpp 6ae772416d6a84427d82f4b25b8b26e100426933 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
>   3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 
> 
> 
> Diff: https://reviews.apache.org/r/58347/diff/2/
> 
> 
> Testing
> -------
> 
> libprocess-tests (using automake and CMake with macOS, Linux, Windows)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.

Posted by Jan Schlicht <ja...@mesosphere.io>.

> On April 11, 2017, 8:45 p.m., Neil Conway wrote:
> > I'm curious what the goal of these assertions is: to fail the test (at runtime) if the current version of GTest is not thread-safe, right? It seems weird to be doing that at runtime, since whether GTest is threadsafe or not seems to be a compile-time property.
> > 
> > Would it make more sense to just avoid compiling these tests if `GTEST_IS_THREADSAFE` is not defined?

Yes, we could do something like
```
#if GTEST_IS_THREADSAFE
#define TEST_THREADSAFE(test_case_name, test_name) \
  TEST(test_case_name, test_name)
#else
#define TEST_THREADSAFE(test_case_name, test_name) \
  TEST(test_case_name, DISABLED_##test_name)
#endif
```
similar to the `TEST_TEMP_DISABLED_ON_WINDOWS` macros, or use a `THREADSAFE_` prefix in the test name and add a filter for these tests. I prefer the second solution, because it allows a test case to have mutiple prefixes and will implement that.


> On April 11, 2017, 8:45 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp
> > Line 294 (original), 294 (patched)
> > <https://reviews.apache.org/r/58347/diff/1/?file=1687944#file1687944line294>
> >
> >     Seems like the reference to `GTEST_IS_THREADSAFE` should be updated, here and elsewhere.
> 
> Joseph Wu wrote:
>     One thing to note: Upgrading gtest to 1.8 will bring thread-safety support to Windows ( https://reviews.apache.org/r/58349/ ), so the macro will actually be defined.

Good point. I'll re-enable these tests.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review171598
-----------------------------------------------------------


On April 11, 2017, 2:27 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 2:27 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7193
>     https://issues.apache.org/jira/browse/MESOS-7193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using 'GTEST_IS_THREADSAFE' in asserts to fail tests that need
> thread-safety early is problematic, because it may be undefined.
> Instead, a new assertion is introduced that evaluates
> 'GTEST_IS_THREADSAFE' and succeeds or fails accordingly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 27077ac9047447fc4c52cc76ab26420e5bc79418 
>   3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
>   3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
>   3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
>   3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 
> 
> 
> Diff: https://reviews.apache.org/r/58347/diff/1/
> 
> 
> Testing
> -------
> 
> libprocess-tests (using automake and CMake with macOS, Linux, Windows)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review171598
-----------------------------------------------------------



I'm curious what the goal of these assertions is: to fail the test (at runtime) if the current version of GTest is not thread-safe, right? It seems weird to be doing that at runtime, since whether GTest is threadsafe or not seems to be a compile-time property.

Would it make more sense to just avoid compiling these tests if `GTEST_IS_THREADSAFE` is not defined?


3rdparty/libprocess/src/tests/process_tests.cpp
Line 294 (original), 294 (patched)
<https://reviews.apache.org/r/58347/#comment244544>

    Seems like the reference to `GTEST_IS_THREADSAFE` should be updated, here and elsewhere.


- Neil Conway


On April 11, 2017, 12:27 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 12:27 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7193
>     https://issues.apache.org/jira/browse/MESOS-7193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using 'GTEST_IS_THREADSAFE' in asserts to fail tests that need
> thread-safety early is problematic, because it may be undefined.
> Instead, a new assertion is introduced that evaluates
> 'GTEST_IS_THREADSAFE' and succeeds or fails accordingly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 27077ac9047447fc4c52cc76ab26420e5bc79418 
>   3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
>   3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
>   3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
>   3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 
> 
> 
> Diff: https://reviews.apache.org/r/58347/diff/1/
> 
> 
> Testing
> -------
> 
> libprocess-tests (using automake and CMake with macOS, Linux, Windows)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review174731
-----------------------------------------------------------



Can you rebase this, please?

- Neil Conway


On April 24, 2017, 11:22 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 11:22 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7193
>     https://issues.apache.org/jira/browse/MESOS-7193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of using asserts that would fail a test at runtime when
> thread-safety of the test environment isn't given, these tests are now
> filtered out before running the tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
>   3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
>   3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
>   3rdparty/libprocess/src/tests/main.cpp 6ae772416d6a84427d82f4b25b8b26e100426933 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
>   3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 
> 
> 
> Diff: https://reviews.apache.org/r/58347/diff/2/
> 
> 
> Testing
> -------
> 
> libprocess-tests (using automake and CMake with macOS, Linux, Windows)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review175177
-----------------------------------------------------------


Ship it!




Ship It!

- Neil Conway


On May 15, 2017, 10:25 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 10:25 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7193
>     https://issues.apache.org/jira/browse/MESOS-7193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of using asserts that would fail a test at runtime when
> thread-safety of the test environment isn't given, these tests are now
> filtered out before running the tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
>   3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
>   3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
>   3rdparty/libprocess/src/tests/main.cpp 23eead809d1f0ddc9a28f492005ff325701bac59 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
>   3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 
> 
> 
> Diff: https://reviews.apache.org/r/58347/diff/3/
> 
> 
> Testing
> -------
> 
> tested in https://reviews.apache.org/r/58348/, don't commit without commiting 58348.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
-----------------------------------------------------------

(Updated May 15, 2017, 12:25 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Bugs: MESOS-7193
    https://issues.apache.org/jira/browse/MESOS-7193


Repository: mesos


Description
-------

Instead of using asserts that would fail a test at runtime when
thread-safety of the test environment isn't given, these tests are now
filtered out before running the tests.


Diffs
-----

  3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
  3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
  3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
  3rdparty/libprocess/src/tests/main.cpp 23eead809d1f0ddc9a28f492005ff325701bac59 
  3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
  3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
  3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 


Diff: https://reviews.apache.org/r/58347/diff/3/


Testing (updated)
-------

tested in https://reviews.apache.org/r/58348/, don't commit without commiting 58348.


Thanks,

Jan Schlicht

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
-----------------------------------------------------------

(Updated May 15, 2017, 12:24 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Changes
-------

Rebased.


Bugs: MESOS-7193
    https://issues.apache.org/jira/browse/MESOS-7193


Repository: mesos


Description
-------

Instead of using asserts that would fail a test at runtime when
thread-safety of the test environment isn't given, these tests are now
filtered out before running the tests.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
  3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
  3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
  3rdparty/libprocess/src/tests/main.cpp 23eead809d1f0ddc9a28f492005ff325701bac59 
  3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
  3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
  3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 


Diff: https://reviews.apache.org/r/58347/diff/3/

Changes: https://reviews.apache.org/r/58347/diff/2-3/


Testing (updated)
-------

tested in https://reviews.apache.org/r/58348/


Thanks,

Jan Schlicht

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review174734
-----------------------------------------------------------



Also please double-check that this RR builds by itself (applying the patch with fuzziness and compiling doesn't build).

- Neil Conway


On April 24, 2017, 11:22 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 11:22 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7193
>     https://issues.apache.org/jira/browse/MESOS-7193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of using asserts that would fail a test at runtime when
> thread-safety of the test environment isn't given, these tests are now
> filtered out before running the tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
>   3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
>   3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
>   3rdparty/libprocess/src/tests/main.cpp 6ae772416d6a84427d82f4b25b8b26e100426933 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
>   3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 
> 
> 
> Diff: https://reviews.apache.org/r/58347/diff/2/
> 
> 
> Testing
> -------
> 
> libprocess-tests (using automake and CMake with macOS, Linux, Windows)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
-----------------------------------------------------------

(Updated April 24, 2017, 1:22 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Changes
-------

Use a test filter instead of an assert to filter tests that need thread-safety.


Summary (updated)
-----------------

Introduced a filter for test cases that need thread-safety.


Bugs: MESOS-7193
    https://issues.apache.org/jira/browse/MESOS-7193


Repository: mesos


Description (updated)
-------

Instead of using asserts that would fail a test at runtime when
thread-safety of the test environment isn't given, these tests are now
filtered out before running the tests.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd 
  3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
  3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa 
  3rdparty/libprocess/src/tests/main.cpp 6ae772416d6a84427d82f4b25b8b26e100426933 
  3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c 
  3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 
  3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 


Diff: https://reviews.apache.org/r/58347/diff/2/

Changes: https://reviews.apache.org/r/58347/diff/1-2/


Testing
-------

libprocess-tests (using automake and CMake with macOS, Linux, Windows)


Thanks,

Jan Schlicht