[jira] [Updated] (SAMZA-382) SamzaContainer main thread might die without proper cleanup

["Chris Riccomini (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SAMZA-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Riccomini updated SAMZA-382:
----------------------------------

    Attachment: SAMZA-382-0.patch

Attaching a patch. RB at:

https://reviews.apache.org/r/24863/

# Moved main method into a separate method to allow a mock-able JmxServer.
# Wrote a test to validate that the JMX server is not properly called on certain exceptions.
# Made test pass by moving the try block to include all logic in the main method.

This code feels a little ugly. I fiddled around a bit, but every alternative that I came up with made things even uglier, so I just went with the minimal amount of changes to get things fixed.

> SamzaContainer main thread might die without proper cleanup
> -----------------------------------------------------------
>
>                 Key: SAMZA-382
>                 URL: https://issues.apache.org/jira/browse/SAMZA-382
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.8.0
>            Reporter: Chinmay Soman
>             Fix For: 0.8.0
>
>         Attachments: SAMZA-382-0.patch
>
>
> In SamzaContainer, 
> There are some method invocations within 'main' that throw an exception:
> For eg: getTaskNameToSystemStreamPartition (this might happen if there is no SSP for a given task). 
> However, this is outside the try block due to which, it doesn't cleanup properly before dying. The result is that, the AMF thread can still be alive - thus locking up resources in YARN.
> Proposed resolution: Include all such statements within the try block



--
This message was sent by Atlassian JIRA
(v6.2#6252)