[jira] [Commented] (RATIS-302) Bump the version of grpc-java and netty

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589009#comment-16589009 ] 

Hadoop QA commented on RATIS-302:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  1m  1s{color} | {color:red} root generated 3 new + 81 unchanged - 0 fixed = 84 total (was 81) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  7m  1s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m  7s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m  7s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerSlownessDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-08-22 |
| JIRA Issue | RATIS-302 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12936664/RATIS-302.001.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  xml  compile  |
| uname | Linux ace653f4543b 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh |
| git revision | master / 0581246 |
| Default Java | 1.8.0_171 |
| javac | https://builds.apache.org/job/PreCommit-RATIS-Build/307/artifact/out/diff-compile-javac-root.txt |
| unit | https://builds.apache.org/job/PreCommit-RATIS-Build/307/artifact/out/patch-unit-root.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/307/testReport/ |
| modules | C: ratis-proto-shaded U: ratis-proto-shaded |
| Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/307/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Bump the version of grpc-java and netty
> ---------------------------------------
>
>                 Key: RATIS-302
>                 URL: https://issues.apache.org/jira/browse/RATIS-302
>             Project: Ratis
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>         Attachments: RATIS-302.001.patch
>
>
> I got multiple errors during ozone tests with ratis:
> {code}
> WARNING: Failed to construct URI for proxy lookup, proceeding without proxy
> java.net.URISyntaxException: Illegal character in hostname at index 13: https://ozone_datanode_3.ozone_default:9858
>         at java.net.URI$Parser.fail(URI.java:2848)
>         at java.net.URI$Parser.parseHostname(URI.java:3387)
>         at java.net.URI$Parser.parseServer(URI.java:3236)
>         at java.net.URI$Parser.parseAuthority(URI.java:3155)
>         at java.net.URI$Parser.parseHierarchical(URI.java:3097)
>         at java.net.URI$Parser.parse(URI.java:3053)
>         at java.net.URI.<init>(URI.java:673)
> {code}
> It came from the shaded io.grpc during the proxy detection. Unfortunately this is a limitation of the docker-compose. I use docker-compose to create clusters but compose use underscore in the dns names which are invalid. It's checked in one of the constructor of the java.net.URI/URL.
> See also: https://github.com/docker/compose/issues/229
> There is no real fix for that. Fortunately in the latest grpc-java the proxy detection part is improved and I can't see similar errors (even if my host names still invalid).
> I propose to use the latest grpc and (just to make it easier) swtich to the same netty which is used by grpc-java.
> I tested the change with ozone pseudo cluster and it worked well.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)