[GitHub] [helix] jiajunwang commented on issue #1661: Flaky test: TestCleanupExternalView.test

[GitBox <gi...@apache.org>]

jiajunwang commented on issue #1661:
URL: https://github.com/apache/helix/issues/1661#issuecomment-854295027


   > Ok, the theory is that the dedup queue for the Async Stages skip some of the EV update.
   > This happens after we greatly boost pipeline speed. So it is possible that during the 1st EV update event is processing, the 2nd EV update event is still in the dedup queue. Then we started to remove the resource. The corresponding EV update event (3rd) is deduped. Same situation might happen for the other EV update events.
   > 
   > Given the cached data in the ClusterEvent object won't be refreshed when the EV update event is picked up, I don't think we should use dedup queue for this specific Stage at least.
   
   Since the dedup queue actually dedups the prior events, there is no concern that the newer event is ignored. And since all Helix logic assume that a later operation can resolve and catch up data gaps between different notifications, so there is no real logic problem here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org