You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "ricardozanini (via GitHub)" <gi...@apache.org> on 2024/05/20 20:00:36 UTC
[PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
ricardozanini opened a new pull request, #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Fixes https://github.com/apache/incubator-kie-issues/issues/1217
Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:
- [ ] You have read the [contributors guide](CONTRIBUTING.md)
- [ ] Your code is properly formatted according to [this configuration](https://github.com/apache/incubator-kie-kogito-runtimes/tree/main/kogito-build/kogito-ide-config)
- [ ] Pull Request title is properly formatted: `KOGITO-XYZ Subject`
- [ ] Pull Request title contains the target branch if not targeting main: `[0.9.x] KOGITO-XYZ Subject`
- [ ] Pull Request contains link to the JIRA issue
- [ ] Pull Request contains link to any dependent or related Pull Request
- [ ] Pull Request contains description of the issue
- [ ] Pull Request does not include fixes for issues other than the main ticket
<details>
<summary>
How to replicate CI configuration locally?
</summary>
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository.
[build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
</details>
<details>
<summary>
How to retest this PR or trigger a specific build:
</summary>
- for <b>pull request checks</b>
Please add comment: <b>Jenkins retest this</b>
- for a <b>specific pull request check</b>
Please add comment: <b>Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] tests</b>
- for <b>quarkus branch checks</b>
Run checks against Quarkus current used branch
Please add comment: <b>Jenkins run quarkus-branch</b>
- for a <b>quarkus branch specific check</b>
Run checks against Quarkus current used branch
Please add comment: <b>Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch</b>
- for <b>quarkus main checks</b>
Run checks against Quarkus main branch
Please add comment: <b>Jenkins run quarkus-main</b>
- for a <b>specific quarkus main check</b>
Run checks against Quarkus main branch
Please add comment: <b>Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-main</b>
- for <b>quarkus lts checks</b>
Run checks against Quarkus lts branch
Please add comment: <b>Jenkins run quarkus-lts</b>
- for a <b>specific quarkus lts check</b>
Run checks against Quarkus lts branch
Please add comment: <b>Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts</b>
- for <b>native checks</b>
Run native checks
Please add comment: <b>Jenkins run native</b>
- for a <b>specific native check</b>
Run native checks
Please add comment: <b>Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native</b>
- for <b>native lts checks</b>
Run native checks against quarkus lts branch
Please add comment: <b>Jenkins run native-lts</b>
- for a <b>specific native lts check</b>
Run native checks against quarkus lts branch
Please add comment: <b>Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native-lts</b>
</details>
<details>
<summary>
How to backport a pull request to a different branch?
</summary>
In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-<branch-name>`, where `<branch-name>` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch).
> **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.
Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.
> **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
</details>
<details>
<summary>
Quarkus-3 PR check is failing ... what to do ?
</summary>
The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.
The first patch, called `0001_before_sh.patch`, is generated from Openrewrite `.ci/environments/quarkus-3/quarkus3.yml` recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.
No panic, there is an easy way to regenerate it. You just need to comment on the PR:
```
jenkins rewrite quarkus-3
```
and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.
Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1609912168
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -213,11 +213,11 @@ String getWorkflowCommonDeploymentRelativePath() {
String getDataIndexEphemeralImage() {
if (isMainBranch()) {
- return "${dataIndexEphemeralImageName}-nightly:latest"
+ return "${dataIndexEphemeralImageName}:main"
}
String version = getKogitoVersion()
if (version.endsWith('-SNAPSHOT')) {
- return "${dataIndexEphemeralImageName}-nightly:${util.getMajorMinorVersion(version)}"
+ return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
}
return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
Review Comment:
@tiagobento I think we need another PR targeting CI changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#issuecomment-2125063284
@ricardozanini @tiagobento fyi https://github.com/apache/incubator-kie-kogito-runtimes/pull/3526 this is an attempt to move Integration tests to -apps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1608590390
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/deployment-no-service.yaml:
##########
@@ -36,7 +36,7 @@ spec:
spec:
containers:
- name: example-deployment-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
isn't this a dead code? the quay.io/kiegroup/process-quarkus-example:latest is years old (with tons of security issues btw).
we don't build such image anywhere that I could find, or am I missing something?
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/pod-deployment-no-service.yaml:
##########
@@ -57,7 +57,7 @@ spec:
defaultMode: 420
containers:
- name: example-deployment-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same question
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/deployment-config-no-service.yaml:
##########
@@ -34,7 +34,7 @@ spec:
spec:
containers:
- name: example-dc-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/pod-deployment-config-no-service.yaml:
##########
@@ -81,7 +81,7 @@ spec:
readOnly: true
mountPath: /var/run/secrets/kubernetes.io/serviceaccount
terminationMessagePolicy: File
- image: 'quay.io/kiegroup/process-quarkus-example:latest'
+ image: 'docker.io/apache/incubator-kie-process-quarkus-example:latest'
Review Comment:
and here
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/pod-deployment-config-no-service.yaml:
##########
@@ -149,5 +149,5 @@ status:
state:
running:
startedAt: '2022-08-22T17:30:29Z'
- image: 'quay.io/kiegroup/process-quarkus-example:latest'
+ image: 'docker.io/apache/incubator-kie-process-quarkus-example:latest'
Review Comment:
here we go again :)
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/pod-deployment-no-service.yaml:
##########
@@ -121,6 +121,6 @@ status:
lastState: {}
ready: true
restartCount: 0
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same
##########
quarkus/addons/tracing-decision/deployment/src/main/resources/application.properties:
##########
@@ -17,4 +17,4 @@
# under the License.
#
-quarkus.kogito.dev-services-trusty.image-name=quay.io/kiegroup/kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
+quarkus.kogito.dev-services-trusty.image-name=docker.io/apache/incubator-kie-kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
Review Comment:
where this image is published?
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/pod/pod-no-service.yaml:
##########
@@ -64,5 +64,5 @@ status:
lastState: {}
ready: true
restartCount: 0
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/deployment.yaml:
##########
@@ -35,7 +35,7 @@ spec:
spec:
containers:
- name: example-deployment-with-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same question
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deployment/replica-set-deployment-no-service.yaml:
##########
@@ -46,7 +46,7 @@ spec:
spec:
containers:
- name: example-deployment-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
same
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/statefulset/statefulset-pod-no-service.yaml:
##########
@@ -126,6 +126,6 @@ status:
lastState: {}
ready: true
restartCount: 0
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/tracing-decision/integration-tests/src/test/resources/application.properties:
##########
@@ -31,6 +31,6 @@ mp.messaging.outgoing.kogito-tracing-model.topic=kogito-tracing-model
mp.messaging.outgoing.kogito-tracing-model.value.serializer=org.apache.kafka.common.serialization.StringSerializer
mp.messaging.outgoing.kogito-tracing-model.auto.offset.reset=earliest
-quarkus.kogito.dev-services-trusty.image-name=quay.io/kiegroup/kogito-trusty-postgresql:latest
+quarkus.kogito.dev-services-trusty.image-name=docker.io/apache/incubator-kie-kogito-trusty-postgresql:latest
Review Comment:
can't find this image source; mind help locate it?
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/statefulset/statefulset-pod-no-service.yaml:
##########
@@ -59,7 +59,7 @@ spec:
defaultMode: 420
containers:
- name: example-statefulset-without-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/deployment-config.yaml:
##########
@@ -34,7 +34,7 @@ spec:
spec:
containers:
- name: example-dc-with-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
here too
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/pod/pod-no-service.yaml:
##########
@@ -26,7 +26,7 @@ metadata:
spec:
containers:
- name: process-quarkus-example-pod-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/pod/pod-no-service-custom-port-name.yaml:
##########
@@ -26,7 +26,7 @@ metadata:
spec:
containers:
- name: pod-no-service-custom-port
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/statefulset/statefulset.yaml:
##########
@@ -36,7 +36,7 @@ spec:
spec:
containers:
- name: example-statefulset-with-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/deploymentConfig/replication-controller-dc-no-svc.yaml:
##########
@@ -26,7 +26,7 @@ metadata:
openshift.io/deployment.status-reason: config change
openshift.io/deployment.replicas: '1'
openshift.io/encoded-deployment-config: >
- {"kind":"DeploymentConfig","apiVersion":"apps.openshift.io/v1","metadata":{"name":"example-dc-no-service","namespace":"serverless-workflow-greeting-quarkus","uid":"a01d76e9-6b3a-48bf-8224-acb9de3c4ca0","resourceVersion":"1127454401","generation":1,"creationTimestamp":"2022-08-22T17:30:09Z","labels":{"app":"example-dc-no-service"},"managedFields":[{"manager":"Mozilla","operation":"Update","apiVersion":"apps.openshift.io/v1","time":"2022-08-22T17:30:09Z","fieldsType":"FieldsV1","fieldsV1":{"f:metadata":{"f:labels":{".":{},"f:app":{}}},"f:spec":{"f:replicas":{},"f:selector":{".":{},"f:app":{}},"f:strategy":{"f:activeDeadlineSeconds":{},"f:rollingParams":{".":{},"f:intervalSeconds":{},"f:maxSurge":{},"f:maxUnavailable":{},"f:timeoutSeconds":{},"f:updatePeriodSeconds":{}},"f:type":{}},"f:template":{".":{},"f:metadata":{".":{},"f:creationTimestamp":{},"f:labels":{".":{},"f:app":{}}},"f:spec":{".":{},"f:containers":{".":{},"k:{\"name\":\"example-dc-no-service\"}":{".":{},"f:image":{}
,"f:imagePullPolicy":{},"f:name":{},"f:ports":{".":{},"k:{\"containerPort\":8009,\"protocol\":\"TCP\"}":{".":{},"f:containerPort":{},"f:name":{},"f:protocol":{}},"k:{\"containerPort\":8080,\"protocol\":\"TCP\"}":{".":{},"f:containerPort":{},"f:name":{},"f:protocol":{}}},"f:resources":{},"f:terminationMessagePath":{},"f:terminationMessagePolicy":{}}},"f:dnsPolicy":{},"f:restartPolicy":{},"f:schedulerName":{},"f:securityContext":{},"f:terminationGracePeriodSeconds":{}}},"f:triggers":{}}}},{"manager":"openshift-controller-manager","operation":"Update","apiVersion":"apps.openshift.io/v1","time":"2022-08-22T17:30:09Z","fieldsType":"FieldsV1","fieldsV1":{"f:status":{"f:details":{".":{},"f:causes":{},"f:message":{}},"f:latestVersion":{}}},"subresource":"status"}]},"spec":{"strategy":{"type":"Rolling","rollingParams":{"updatePeriodSeconds":1,"intervalSeconds":1,"timeoutSeconds":600,"maxUnavailable":"25%","maxSurge":"25%"},"resources":{},"activeDeadlineSeconds":21600},"triggers":[{"type":"Co
nfigChange"}],"replicas":1,"revisionHistoryLimit":10,"test":false,"selector":{"app":"example-dc-no-service"},"template":{"metadata":{"creationTimestamp":null,"labels":{"app":"example-dc-no-service"}},"spec":{"containers":[{"name":"example-dc-no-service","image":"quay.io/kiegroup/process-quarkus-example:latest","ports":[{"name":"http","containerPort":8080,"protocol":"TCP"},{"name":"another-http","containerPort":8009,"protocol":"TCP"}],"resources":{},"terminationMessagePath":"/dev/termination-log","terminationMessagePolicy":"File","imagePullPolicy":"Always"}],"restartPolicy":"Always","terminationGracePeriodSeconds":30,"dnsPolicy":"ClusterFirst","securityContext":{},"schedulerName":"default-scheduler"}}},"status":{"latestVersion":1,"observedGeneration":0,"replicas":0,"updatedReplicas":0,"availableReplicas":0,"unavailableReplicas":0,"details":{"message":"config
+ {"kind":"DeploymentConfig","apiVersion":"apps.openshift.io/v1","metadata":{"name":"example-dc-no-service","namespace":"serverless-workflow-greeting-quarkus","uid":"a01d76e9-6b3a-48bf-8224-acb9de3c4ca0","resourceVersion":"1127454401","generation":1,"creationTimestamp":"2022-08-22T17:30:09Z","labels":{"app":"example-dc-no-service"},"managedFields":[{"manager":"Mozilla","operation":"Update","apiVersion":"apps.openshift.io/v1","time":"2022-08-22T17:30:09Z","fieldsType":"FieldsV1","fieldsV1":{"f:metadata":{"f:labels":{".":{},"f:app":{}}},"f:spec":{"f:replicas":{},"f:selector":{".":{},"f:app":{}},"f:strategy":{"f:activeDeadlineSeconds":{},"f:rollingParams":{".":{},"f:intervalSeconds":{},"f:maxSurge":{},"f:maxUnavailable":{},"f:timeoutSeconds":{},"f:updatePeriodSeconds":{}},"f:type":{}},"f:template":{".":{},"f:metadata":{".":{},"f:creationTimestamp":{},"f:labels":{".":{},"f:app":{}}},"f:spec":{".":{},"f:containers":{".":{},"k:{\"name\":\"example-dc-no-service\"}":{".":{},"f:image":{}
,"f:imagePullPolicy":{},"f:name":{},"f:ports":{".":{},"k:{\"containerPort\":8009,\"protocol\":\"TCP\"}":{".":{},"f:containerPort":{},"f:name":{},"f:protocol":{}},"k:{\"containerPort\":8080,\"protocol\":\"TCP\"}":{".":{},"f:containerPort":{},"f:name":{},"f:protocol":{}}},"f:resources":{},"f:terminationMessagePath":{},"f:terminationMessagePolicy":{}}},"f:dnsPolicy":{},"f:restartPolicy":{},"f:schedulerName":{},"f:securityContext":{},"f:terminationGracePeriodSeconds":{}}},"f:triggers":{}}}},{"manager":"openshift-controller-manager","operation":"Update","apiVersion":"apps.openshift.io/v1","time":"2022-08-22T17:30:09Z","fieldsType":"FieldsV1","fieldsV1":{"f:status":{"f:details":{".":{},"f:causes":{},"f:message":{}},"f:latestVersion":{}}},"subresource":"status"}]},"spec":{"strategy":{"type":"Rolling","rollingParams":{"updatePeriodSeconds":1,"intervalSeconds":1,"timeoutSeconds":600,"maxUnavailable":"25%","maxSurge":"25%"},"resources":{},"activeDeadlineSeconds":21600},"triggers":[{"type":"Co
nfigChange"}],"replicas":1,"revisionHistoryLimit":10,"test":false,"selector":{"app":"example-dc-no-service"},"template":{"metadata":{"creationTimestamp":null,"labels":{"app":"example-dc-no-service"}},"spec":{"containers":[{"name":"example-dc-no-service","image":"docker.io/apache/incubator-kie-process-quarkus-example:latest","ports":[{"name":"http","containerPort":8080,"protocol":"TCP"},{"name":"another-http","containerPort":8009,"protocol":"TCP"}],"resources":{},"terminationMessagePath":"/dev/termination-log","terminationMessagePolicy":"File","imagePullPolicy":"Always"}],"restartPolicy":"Always","terminationGracePeriodSeconds":30,"dnsPolicy":"ClusterFirst","securityContext":{},"schedulerName":"default-scheduler"}}},"status":{"latestVersion":1,"observedGeneration":0,"replicas":0,"updatedReplicas":0,"availableReplicas":0,"unavailableReplicas":0,"details":{"message":"config
Review Comment:
one more
##########
quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/resources/statefulset/statefulset-no-service.yaml:
##########
@@ -36,7 +36,7 @@ spec:
spec:
containers:
- name: process-quarkus-example-statefulset-no-service
- image: quay.io/kiegroup/process-quarkus-example:latest
+ image: docker.io/apache/incubator-kie-process-quarkus-example:latest
Review Comment:
one more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#issuecomment-2123057948
@porcelli these are just integration tests that uses these YAMLs as mock resources to check if the integration with the k8s.
See: https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/java/org/kie/kogito/addons/quarkus/fabric8/k8s/service/catalog/DeploymentUtilsTest.java#L61-L62
I'll change to `docker.io/bananas`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#issuecomment-2123575022
**PR job** `#2` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3525/2/display/redirect
**Test results:**
- PASSED: 3266
- FAILED: 1
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3525/2/testReport/org.kie.kogito.tracing/QuarkusTracingAddonDevServicesIT/testEvaluateLoanEligibility/">org.kie.kogito.tracing.QuarkusTracingAddonDevServicesIT.testEvaluateLoanEligibility</a></summary>
io.quarkus.builder.BuildException: Build failure: Build failed due to errors<br/> [error]: Build step org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor#startTrustyServiceDevService threw an exception: java.lang.RuntimeException: Failed to start Kogito TrustyService DevServices<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.startTrustyServiceDevService(KogitoDevServicesProcessor.java:145)<br/> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<br/> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)<br/> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<br/> at java.base/java.lang.reflect.Method.invoke(Method.java:568)<br/> at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)<br/> at io.quarkus.builder.BuildContext.run(BuildContext.java:256)<br/> at org.jbos
s.threads.ContextHandler$1.runWith(ContextHandler.java:18)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)<br/> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)<br/> at java.base/java.lang.Thread.run(Thread.java:833)<br/> at org.jboss.threads.JBossThread.run(JBossThread.java:501)<br/>Caused by: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/apache/incubator-kie-kogito-trusty-postgresql:latest, imagePullPolicy=AlwaysPullPolicy(), imageNameSubstitutor=Chained substitutor of 'DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')' and then 'Kogito Image Name Substitutor')<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.lambda$startTrustyService$8(KogitoDevServicesProcessor.java:271)<br/> at java.base/java.u
til.Optional.orElseGet(Optional.java:364)<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.startTrustyService(KogitoDevServicesProcessor.java:276)<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.startTrustyServiceDevService(KogitoDevServicesProcessor.java:133)<br/> ... 11 more<br/>Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/apache/incubator-kie-kogito-trusty-postgresql:latest, imagePullPolicy=AlwaysPullPolicy(), imageNameSubstitutor=Chained substitutor of 'DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')' and then 'Kogito Image Name Substitutor')<br/> at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1364)<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)<br/> at org.testcontain
ers.containers.GenericContainer.start(GenericContainer.java:330)<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.lambda$startTrustyService$8(KogitoDevServicesProcessor.java:267)<br/> ... 14 more<br/>Caused by: com.github.dockerjava.api.exception.NotFoundException: Status 404: {"message":"pull access denied for apache/incubator-kie-kogito-trusty-postgresql, repository does not exist or may require 'docker login': denied: requested access to the resource is denied"}<br/><br/> at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:241)<br/> at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269)<br/> at java.base/java.lang.Thread.run(Thread.java:833)<br/>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#issuecomment-2125029652
What is missing here for us to merge it? @ricardozanini @porcelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1609208579
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -213,11 +213,11 @@ String getWorkflowCommonDeploymentRelativePath() {
String getDataIndexEphemeralImage() {
if (isMainBranch()) {
- return "${dataIndexEphemeralImageName}-nightly:latest"
+ return "${dataIndexEphemeralImageName}:main"
}
String version = getKogitoVersion()
if (version.endsWith('-SNAPSHOT')) {
- return "${dataIndexEphemeralImageName}-nightly:${util.getMajorMinorVersion(version)}"
+ return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
}
return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
Review Comment:
With that said, this is not something that should only be done on the deploy job, as the code itself needs to reflect that, so people building locally and developing will have the same behavior. I guess the best solution would be calling:
`mvn versions:set-property -Dproperty=data-index-ephemeral.image -DnewVersion=<new-value>` on this module during commits D and R, as per our release procedure described here: https://docs.google.com/document/d/1t-08b970i9PMBy-TSM64x0RUH46pzwnIhEi-LVeL0lg/edit
This way, the deployment CI doesn't need to alter this property when publishing, and the build from source is always accurate.
Better yet would be creating a new property to hold only have the `tagVersion`, not the full `tag` of the image. This new property (E.g., `data-index-ephemeral.image.tagVersion`) can then be used to compose the existing `data-index-ephemeral.image` property, like `docker.io/apache/incubator-kie-kogito-data-index-ephemeral:${data-index-ephemeral.image.tagVersion}`.
Sorry for dumping the entire reasoning here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#issuecomment-2125057949
> What is missing here for us to merge it? @ricardozanini @porcelli
nothing from my side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#issuecomment-2123061330
thank you @ricardozanini for clarifying
great idea to use bananas... so we don't confuse ourselves :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1608922285
##########
quarkus/addons/tracing-decision/integration-tests/src/test/resources/application.properties:
##########
@@ -31,6 +31,6 @@ mp.messaging.outgoing.kogito-tracing-model.topic=kogito-tracing-model
mp.messaging.outgoing.kogito-tracing-model.value.serializer=org.apache.kafka.common.serialization.StringSerializer
mp.messaging.outgoing.kogito-tracing-model.auto.offset.reset=earliest
-quarkus.kogito.dev-services-trusty.image-name=quay.io/kiegroup/kogito-trusty-postgresql:latest
+quarkus.kogito.dev-services-trusty.image-name=docker.io/apache/incubator-kie-kogito-trusty-postgresql:latest
Review Comment:
Same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1609909843
##########
quarkus/addons/tracing-decision/deployment/src/main/resources/application.properties:
##########
@@ -17,4 +17,4 @@
# under the License.
#
-quarkus.kogito.dev-services-trusty.image-name=quay.io/kiegroup/kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
+quarkus.kogito.dev-services-trusty.image-name=docker.io/apache/incubator-kie-kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
Review Comment:
I think this property is for the devservice. We should remove the devservice or review it. I recommend doing so in another PR. Waiting for @gitgabrio inputs. :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1610166716
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -213,11 +213,11 @@ String getWorkflowCommonDeploymentRelativePath() {
String getDataIndexEphemeralImage() {
if (isMainBranch()) {
- return "${dataIndexEphemeralImageName}-nightly:latest"
+ return "${dataIndexEphemeralImageName}:main"
}
String version = getKogitoVersion()
if (version.endsWith('-SNAPSHOT')) {
- return "${dataIndexEphemeralImageName}-nightly:${util.getMajorMinorVersion(version)}"
+ return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
}
return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
Review Comment:
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#issuecomment-2125061717
we need to be thoughtful that the build will be broken for a quite due the image references of data-index... but I'm ok to merge as there is no way to solve this in one shot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1608922041
##########
quarkus/addons/tracing-decision/deployment/src/main/resources/application.properties:
##########
@@ -17,4 +17,4 @@
# under the License.
#
-quarkus.kogito.dev-services-trusty.image-name=quay.io/kiegroup/kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
+quarkus.kogito.dev-services-trusty.image-name=docker.io/apache/incubator-kie-kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
Review Comment:
It's not. We've deprecated it. Hence, we can either keep this image here for ubiquity, keep the outdated, or remove this addon for good. I'd rather take this decision for the maintainers of this addon. @gitgabrio do you know?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1608926340
##########
quarkus/addons/tracing-decision/deployment/src/main/resources/application.properties:
##########
@@ -17,4 +17,4 @@
# under the License.
#
-quarkus.kogito.dev-services-trusty.image-name=quay.io/kiegroup/kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
+quarkus.kogito.dev-services-trusty.image-name=docker.io/apache/incubator-kie-kogito-trusty-postgresql:${version.org.kie.kogito.trusty-service-postgresql}
Review Comment:
k, thank you for the clarifications.
I would like to preserve as much as possible the tracing decision, but it has to adjust to remove the image reference that has been removed.
@gitgabrio would be possible to adjust the code to avoid use the image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1609205741
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -213,11 +213,11 @@ String getWorkflowCommonDeploymentRelativePath() {
String getDataIndexEphemeralImage() {
if (isMainBranch()) {
- return "${dataIndexEphemeralImageName}-nightly:latest"
+ return "${dataIndexEphemeralImageName}:main"
}
String version = getKogitoVersion()
if (version.endsWith('-SNAPSHOT')) {
- return "${dataIndexEphemeralImageName}-nightly:${util.getMajorMinorVersion(version)}"
+ return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
}
return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
Review Comment:
I think this needs adjustment.. For the main branch, the tag would be `main`, that's fine. But when the branch is not `main`, we actually agreed to use the branch name to represent the stream, so the tag of this image would be 10.0.x. Now when we're doing an ACTUAL release, meaning versions does not end with `-SNAPSHOT`, then that's when we're supposed to use `getMajorMinor()`.. Let me know if I'm missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1609208579
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -213,11 +213,11 @@ String getWorkflowCommonDeploymentRelativePath() {
String getDataIndexEphemeralImage() {
if (isMainBranch()) {
- return "${dataIndexEphemeralImageName}-nightly:latest"
+ return "${dataIndexEphemeralImageName}:main"
}
String version = getKogitoVersion()
if (version.endsWith('-SNAPSHOT')) {
- return "${dataIndexEphemeralImageName}-nightly:${util.getMajorMinorVersion(version)}"
+ return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
}
return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
Review Comment:
With that said, this is not something that should only be done on the deploy job, as the code itself needs to reflect that, so people building locally and developing will have the same behavior. I guess the best solution would be calling:
`mvn versions:set-property -Dproperty=data-index-ephemeral.image -DnewVersion=<new-value>` on this module during commits D and R, as per our release procedure described here: https://docs.google.com/document/d/1t-08b970i9PMBy-TSM64x0RUH46pzwnIhEi-LVeL0lg/edit
This way, the deployment CI doesn't need to alter this property when publishing, and the build from source is always accurate.
Sorry for dumping the entire reasoning here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#discussion_r1609206454
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -213,11 +213,11 @@ String getWorkflowCommonDeploymentRelativePath() {
String getDataIndexEphemeralImage() {
if (isMainBranch()) {
- return "${dataIndexEphemeralImageName}-nightly:latest"
+ return "${dataIndexEphemeralImageName}:main"
}
String version = getKogitoVersion()
if (version.endsWith('-SNAPSHOT')) {
- return "${dataIndexEphemeralImageName}-nightly:${util.getMajorMinorVersion(version)}"
+ return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
}
return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
Review Comment:
In practice:
if version ends in -SNAPSHOT
tagVersion = branch name
else
tagVersion = getMajorMinor(...)
##########
.ci/jenkins/Jenkinsfile.setup-branch:
##########
@@ -213,11 +213,11 @@ String getWorkflowCommonDeploymentRelativePath() {
String getDataIndexEphemeralImage() {
if (isMainBranch()) {
- return "${dataIndexEphemeralImageName}-nightly:latest"
+ return "${dataIndexEphemeralImageName}:main"
}
String version = getKogitoVersion()
if (version.endsWith('-SNAPSHOT')) {
- return "${dataIndexEphemeralImageName}-nightly:${util.getMajorMinorVersion(version)}"
+ return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
}
return "${dataIndexEphemeralImageName}:${util.getMajorMinorVersion(version)}"
Review Comment:
In practice:
```
if version ends in -SNAPSHOT
tagVersion = branch name
else
tagVersion = getMajorMinor(...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix kie-issues #1217 - Replace quay.io with docker.io [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3525:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525#issuecomment-2121371015
**PR job** `#1` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3525 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3525/1/display/redirect
**Test results:**
- PASSED: 3266
- FAILED: 1
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3525/1/testReport/org.kie.kogito.tracing/QuarkusTracingAddonDevServicesIT/testEvaluateLoanEligibility/">org.kie.kogito.tracing.QuarkusTracingAddonDevServicesIT.testEvaluateLoanEligibility</a></summary>
io.quarkus.builder.BuildException: Build failure: Build failed due to errors<br/> [error]: Build step org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor#startTrustyServiceDevService threw an exception: java.lang.RuntimeException: Failed to start Kogito TrustyService DevServices<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.startTrustyServiceDevService(KogitoDevServicesProcessor.java:145)<br/> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<br/> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)<br/> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<br/> at java.base/java.lang.reflect.Method.invoke(Method.java:568)<br/> at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)<br/> at io.quarkus.builder.BuildContext.run(BuildContext.java:256)<br/> at org.jbos
s.threads.ContextHandler$1.runWith(ContextHandler.java:18)<br/> at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)<br/> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)<br/> at java.base/java.lang.Thread.run(Thread.java:833)<br/> at org.jboss.threads.JBossThread.run(JBossThread.java:501)<br/>Caused by: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/apache/incubator-kie-kogito-trusty-postgresql:latest, imagePullPolicy=AlwaysPullPolicy(), imageNameSubstitutor=Chained substitutor of 'DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')' and then 'Kogito Image Name Substitutor')<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.lambda$startTrustyService$8(KogitoDevServicesProcessor.java:271)<br/> at java.base/java.u
til.Optional.orElseGet(Optional.java:364)<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.startTrustyService(KogitoDevServicesProcessor.java:276)<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.startTrustyServiceDevService(KogitoDevServicesProcessor.java:133)<br/> ... 11 more<br/>Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/apache/incubator-kie-kogito-trusty-postgresql:latest, imagePullPolicy=AlwaysPullPolicy(), imageNameSubstitutor=Chained substitutor of 'DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')' and then 'Kogito Image Name Substitutor')<br/> at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1364)<br/> at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)<br/> at org.testcontain
ers.containers.GenericContainer.start(GenericContainer.java:330)<br/> at org.kie.kogito.tracing.decision.quarkus.deployment.KogitoDevServicesProcessor.lambda$startTrustyService$8(KogitoDevServicesProcessor.java:267)<br/> ... 14 more<br/>Caused by: com.github.dockerjava.api.exception.NotFoundException: Status 404: {"message":"pull access denied for apache/incubator-kie-kogito-trusty-postgresql, repository does not exist or may require 'docker login': denied: requested access to the resource is denied"}<br/><br/> at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:241)<br/> at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269)<br/> at java.base/java.lang.Thread.run(Thread.java:833)<br/>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org