[helix] branch master updated: Improve logging for isClusterSetup (#968)

[hu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new 14c21a2  Improve logging for isClusterSetup (#968)
14c21a2 is described below

commit 14c21a227b66c9ad52cc0ecaf5ce040042a6793d
Author: Hunter Lee <hu...@linkedin.com>
AuthorDate: Fri Apr 24 15:40:09 2020 -0700

    Improve logging for isClusterSetup (#968)
    
    If isClusterSetup fails, we don't get the errorMsg. This PR improves that behavior by making it a warn log.
---
 helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java b/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
index d2c80c8..647f3c2 100644
--- a/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
+++ b/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
@@ -112,13 +112,13 @@ public final class ZKUtil {
     for (int i = 0; i < ret.length; i++) {
       if (!ret[i]) {
         isValid = false;
-        errorMsg.append("Invalid cluster setup, missing znode path: ").append(requiredPaths.get(i))
-            .append("\n");
+        errorMsg.append("Invalid cluster setup for cluster: ").append(clusterName)
+            .append(", missing znode path: ").append(requiredPaths.get(i)).append("\n");
       }
     }
 
     if (!isValid) {
-      logger.debug(errorMsg.toString());
+      logger.warn(errorMsg.toString());
     }
 
     return isValid;