You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2026/08/07 04:19:33 UTC
[PR] chore(dev/release): verify free-threaded wheels too [arrow-adbc]
lidavidm opened a new pull request, #4669:
URL: https://github.com/apache/arrow-adbc/pull/4669
Closes #3824.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): verify free-threaded wheels too [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #4669:
URL: https://github.com/apache/arrow-adbc/pull/4669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): verify free-threaded wheels too [arrow-adbc]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4669:
URL: https://github.com/apache/arrow-adbc/pull/4669#discussion_r3733435560
##########
dev/release/verify-release-candidate.sh:
##########
@@ -818,13 +824,13 @@ test_linux_wheels() {
local arch="x86_64"
fi
- local python_versions="${TEST_PYTHON_VERSIONS:-3.10 3.11 3.12 3.13 3.14}"
+ local python_versions="${TEST_PYTHON_VERSIONS:-3.10 3.11 3.12 3.13 3.14 3.14t}"
Review Comment:
The default was extended only for Linux, while `test_macos_wheels` still defaults through 3.14 and continues to strip/pass versions using its old suffix handling. This leaves macOS free-threaded wheels unverified even though #3824 explicitly requests adding 3.14t to both Linux and macOS verification. Please update the macOS loop to include 3.14t and pass the suffixed version through the new Conda setup as well.
##########
dev/release/verify-release-candidate.sh:
##########
@@ -818,13 +824,13 @@ test_linux_wheels() {
local arch="x86_64"
fi
- local python_versions="${TEST_PYTHON_VERSIONS:-3.10 3.11 3.12 3.13 3.14}"
+ local python_versions="${TEST_PYTHON_VERSIONS:-3.10 3.11 3.12 3.13 3.14 3.14t}"
for python in ${python_versions}; do
- local pyver=${python/m}
- show_header "Testing Python ${pyver} wheel for platform manylinux"
- CONDA_ENV=wheel-${pyver}-${arch} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1
- VENV_ENV=wheel-${pyver}-${arch} PYTHON_VERSION=${pyver} maybe_setup_virtualenv || continue
+ local pyver=${python/t}
+ show_header "Testing Python ${python} wheel for platform manylinux"
+ CONDA_ENV=wheel-${python}-${arch} PYTHON_VERSION=${python} maybe_setup_conda || exit 1
+ VENV_ENV=wheel-${python}-${arch} PYTHON_VERSION=${python} maybe_setup_virtualenv || continue
Review Comment:
The free-threaded test is not forced to run with the GIL disabled. Existing free-threaded wheel checks do this explicitly (`compose.yaml:235` and `.github/workflows/packaging.yml:912`); without `PYTHON_GIL=0`, importing an extension that does not declare free-threading support can silently re-enable the GIL, allowing this release check to pass without exercising the intended mode. Set `PYTHON_GIL=0` when invoking the test script for a `t` version (or centralize this detection in that script).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org