You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by ff...@apache.org on 2015/04/10 05:56:27 UTC
karaf git commit: [KARAF-3631]FeaturesService hides stacktraces for
some exceptions
Repository: karaf
Updated Branches:
refs/heads/karaf-3.0.x c5df43c01 -> d4169f657
[KARAF-3631]FeaturesService hides stacktraces for some exceptions
Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/d4169f65
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/d4169f65
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/d4169f65
Branch: refs/heads/karaf-3.0.x
Commit: d4169f6576adb3b569912fbdc2a7c821b2c7443a
Parents: c5df43c
Author: Freeman Fang <fr...@gmail.com>
Authored: Fri Apr 10 11:56:05 2015 +0800
Committer: Freeman Fang <fr...@gmail.com>
Committed: Fri Apr 10 11:56:05 2015 +0800
----------------------------------------------------------------------
.../apache/karaf/features/command/InstallFeatureCommand.java | 5 +++++
.../main/java/org/apache/karaf/features/FeaturesService.java | 1 +
.../org/apache/karaf/features/internal/FeaturesServiceImpl.java | 3 +++
3 files changed, 9 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/karaf/blob/d4169f65/features/command/src/main/java/org/apache/karaf/features/command/InstallFeatureCommand.java
----------------------------------------------------------------------
diff --git a/features/command/src/main/java/org/apache/karaf/features/command/InstallFeatureCommand.java b/features/command/src/main/java/org/apache/karaf/features/command/InstallFeatureCommand.java
index a9eccb3..2b1f107 100644
--- a/features/command/src/main/java/org/apache/karaf/features/command/InstallFeatureCommand.java
+++ b/features/command/src/main/java/org/apache/karaf/features/command/InstallFeatureCommand.java
@@ -39,6 +39,8 @@ public class InstallFeatureCommand extends FeaturesCommandSupport {
boolean noStart;
@Option(name = "-v", aliases = "--verbose", description = "Explain what is being done", required = false, multiValued = false)
boolean verbose;
+ @Option(name = "-p", aliases = "--print-exception-per-feature", description = "Log a warn message per each feature installation failure", required = false, multiValued = false)
+ boolean print;
protected void doExecute(FeaturesService admin) throws Exception {
for (String feature : features) {
@@ -64,6 +66,9 @@ public class InstallFeatureCommand extends FeaturesCommandSupport {
if (verbose) {
options.add(FeaturesService.Option.Verbose);
}
+ if (print) {
+ options.add(FeaturesService.Option.PrintExecptionPerFeature);
+ }
admin.installFeature(name, version, options);
}
}
http://git-wip-us.apache.org/repos/asf/karaf/blob/d4169f65/features/core/src/main/java/org/apache/karaf/features/FeaturesService.java
----------------------------------------------------------------------
diff --git a/features/core/src/main/java/org/apache/karaf/features/FeaturesService.java b/features/core/src/main/java/org/apache/karaf/features/FeaturesService.java
index dc3b724..52bbcec 100644
--- a/features/core/src/main/java/org/apache/karaf/features/FeaturesService.java
+++ b/features/core/src/main/java/org/apache/karaf/features/FeaturesService.java
@@ -31,6 +31,7 @@ public interface FeaturesService {
NoAutoRefreshBundles,
NoAutoStartBundles,
ContinueBatchOnFailure,
+ PrintExecptionPerFeature,
Verbose
}
http://git-wip-us.apache.org/repos/asf/karaf/blob/d4169f65/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java
----------------------------------------------------------------------
diff --git a/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java b/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java
index b79f110..a24eeb9 100644
--- a/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java
+++ b/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java
@@ -378,6 +378,9 @@ public class FeaturesServiceImpl implements FeaturesService {
installFeature(feature, options);
} catch (Exception e) {
exceptions.add(e);
+ if (options.contains(Option.PrintExecptionPerFeature)) {
+ LOGGER.warn("Error when installing feature {}: {}", feature.getName(), e);
+ }
}
}
if (!exceptions.isEmpty()) {