[jira] [Commented] (MESOS-4070) numify() handles negative numbers inconsistently.

["Yong Tang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394706#comment-15394706 ] 

Yong Tang commented on MESOS-4070:
----------------------------------

A new RR has been  posted:
https://reviews.apache.org/r/50473/

The new RR above replaces the old RR (45011).

> numify() handles negative numbers inconsistently.
> -------------------------------------------------
>
>                 Key: MESOS-4070
>                 URL: https://issues.apache.org/jira/browse/MESOS-4070
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: Jie Yu
>            Assignee: Yong Tang
>              Labels: tech-debt
>             Fix For: 1.1.0
>
>
> As pointed by [~neilc] in this review:
> https://reviews.apache.org/r/40988
> {noformat}
> Try<int> num2 = numify<int>("-10");
> EXPECT_SOME_EQ(-10, num2);
> // TODO(neilc): This is inconsistent with the handling of non-hex numbers.
> EXPECT_ERROR(numify<int>("-0x10"));
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)