You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/08 08:29:43 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request, #20880: Refactor dataSourceName in job item progress structure

sandynz opened a new pull request, #20880:
URL: https://github.com/apache/shardingsphere/pull/20880

   Part of #19421.
   
   Changes proposed in this pull request:
     - Move dataSourceName from YamlJobItemIncrementalTasksProgress to InventoryIncrementalJobItemProgress
     - Simplify JobItemIncrementalTasksProgress
     - Add dataSourceName in JobItemContext and MigrationTaskConfiguration
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [x] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #20880: Refactor dataSourceName in job item progress structure

Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #20880:
URL: https://github.com/apache/shardingsphere/pull/20880#issuecomment-1240403129

   Job item will dump data from dataSourceName, make sure dataSourceName could be got from job item progress.
   
   SHOW MIGRATION STATUS might show empty data_source before, since it's got from incremental task progress, but incremental task might be null. e.g.
   ```
   mysql> show migration status 'j0101c6420691764d6e32f3f021ad1bca3b1e';
   +------+-------------+------------------------+--------+-------------------------------+--------------------------+
   | item | data_source | status                 | active | inventory_finished_percentage | incremental_idle_seconds |
   +------+-------------+------------------------+--------+-------------------------------+--------------------------+
   | 0    |             | EXECUTE_INVENTORY_TASK | true   | 100                           | 0                        |
   +------+-------------+------------------------+--------+-------------------------------+--------------------------+
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #20880: Refactor dataSourceName in job item progress structure

Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #20880:
URL: https://github.com/apache/shardingsphere/pull/20880#issuecomment-1240404779

   Previous job item progress structure:
   ```
   incremental:
     dataSourceName: ds_0
     delay:
       lastEventTimestamps: 1661394149000
       latestActiveTimeMillis: 1661394152127
     position: mysql-bin.000020#135747923
   inventory:
     finished:
     - ds_0.t_order#0
   sourceDatabaseType: MySQL
   status: EXECUTE_INCREMENTAL_TASK
   ```
   
   Job item progress structure after changing:
   ```
   dataSourceName: ds_0
   incremental:
     delay:
       lastEventTimestamps: 1662623912000
       latestActiveTimeMillis: 1662623915734
     position: mysql-bin.000020#273397765
   inventory:
     finished:
     - ds_0.t_order_copy#0
   sourceDatabaseType: MySQL
   status: EXECUTE_INCREMENTAL_TASK
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin merged pull request #20880: Refactor dataSourceName in job item progress structure

Posted by GitBox <gi...@apache.org>.
tuichenchuxin merged PR #20880:
URL: https://github.com/apache/shardingsphere/pull/20880


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org