You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/05/02 15:11:06 UTC

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3511
  
    @heytitle, the code generation is only for a few methods, right? So the other methods in the sorter template could be moved into a `NormalizedKeySorterBase` which would be subclasses by the template. Then `NormalizedKeySorter` could also subclass `NormalizedKeySorterBase`. This would reduce the duplicated code and also minimize the amount of code 'hidden' from IDEs in the template.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---